You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/14 14:01:38 UTC
[GitHub] [druid] zihengCat opened a new pull request #9184: New property in
`CoordinatorDynamicConfig` to retain a flexible duration for stale
pendingSegments
zihengCat opened a new pull request #9184: New property in `CoordinatorDynamicConfig` to retain a flexible duration for stale pendingSegments
URL: https://github.com/apache/druid/pull/9184
### Description
Add a new property in `CoordinatorDynamicConfig` to retain a ***flexible*** duration for stale pendingSegments.
Hardcode `Period("P1D")` in `DruidCoordinatorCleanupPendingSegments` isn't flexible enough, open a configurable property to users maybe much better.
```java
private static final Period KEEP_PENDING_SEGMENTS_OFFSET = new Period("P1D");
```
> Note: hardcode in `DruidCoordinatorCleanupPendingSegments`
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths.
- [x] added integration tests.
- [x] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
* `CoordinatorDynamicConfig`
* `DruidCoordinatorCleanupPendingSegments`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9184: New properties in
`DruidCoordinatorConfig` to retain a flexible duration for stale
pendingSegments
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9184: New properties in `DruidCoordinatorConfig` to retain a flexible duration for stale pendingSegments
URL: https://github.com/apache/druid/pull/9184#issuecomment-605113377
Hi @zihengCat, sorry for the late review. Would you tell me more about the motivation of this PR? Currently, the stale pendingSegments are computed by `created time of most recent running task (or complete task if there is no running task) - P1D`. I thought this is safe because 1) when a task is already finished, it's safe to delete all pendingSegments created by that task and 2) when a task is running, its pendingSegments is never deleted by the coordinator. Is there a use case where a flexible retention period is required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] zihengCat commented on issue #9184: New property in
`CoordinatorDynamicConfig` to retain a flexible duration for stale
pendingSegments
Posted by GitBox <gi...@apache.org>.
zihengCat commented on issue #9184: New property in `CoordinatorDynamicConfig` to retain a flexible duration for stale pendingSegments
URL: https://github.com/apache/druid/pull/9184#issuecomment-574613943
@clintropolis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #9184: New properties in
`DruidCoordinatorConfig` to retain a flexible duration for stale
pendingSegments
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9184: New properties in `DruidCoordinatorConfig` to retain a flexible duration for stale pendingSegments
URL: https://github.com/apache/druid/pull/9184#issuecomment-604852572
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #9184: New properties in
`DruidCoordinatorConfig` to retain a flexible duration for stale
pendingSegments
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9184: New properties in `DruidCoordinatorConfig` to retain a flexible duration for stale pendingSegments
URL: https://github.com/apache/druid/pull/9184#issuecomment-605113395
This issue is no longer marked as stale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org