You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by qiuchenjian <gi...@git.apache.org> on 2019/01/02 02:15:28 UTC

[GitHub] carbondata pull request #3041: [CARBONDATA-3218] Fix schema refresh and wron...

Github user qiuchenjian commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3041#discussion_r244655257
  
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java ---
    @@ -234,30 +219,26 @@ public TBase create() {
     
           wrapperTableInfo.setTransactionalTable(isTransactionalTable);
     
    +      CarbonMetadata.getInstance().removeTable(wrapperTableInfo.getTableUniqueName());
           // Step 4: Load metadata info into CarbonMetadata
           CarbonMetadata.getInstance().loadTableMetadata(wrapperTableInfo);
     
    -      cache.carbonTable =
    -          CarbonMetadata.getInstance().getCarbonTable(table.getSchemaName(), table.getTableName());
    -
    -      // cache the table
    -      carbonCache.get().put(table, cache);
    +      cache.setCarbonTable(
    +          CarbonMetadata.getInstance().getCarbonTable(table.getSchemaName(), table.getTableName()));
    --- End diff --
    
    Does it need to consider that CarbonMetadata.getInstance().getCarbonTable(table.getSchemaName(), table.getTableName()) return null ？


---