You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by fo...@apache.org on 2026/10/30 08:17:56 UTC

(parquet-java) branch master updated: Bump com.diffplug.spotless:spotless-maven-plugin from 3.8.0 to 3.10.4 (#3367)

This is an automated email from the ASF dual-hosted git repository.

Fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-java.git


The following commit(s) were added to refs/heads/master by this push:
     new 0b83a69cd Bump com.diffplug.spotless:spotless-maven-plugin from 3.8.0 to 3.10.4 (#3367)
0b83a69cd is described below

commit 0b83a69cd375242a5232c9ba80dbf7348a0deb23
Author: dependabot[bot] <49...@users.noreply.github.com>
AuthorDate: Fri Oct 30 09:17:51 2026 +0100

    Bump com.diffplug.spotless:spotless-maven-plugin from 3.8.0 to 3.10.4 (#3367)
    
    * Bump com.diffplug.spotless:spotless-maven-plugin from 3.8.0 to 3.10.4
    
    Bumps [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) from 3.8.0 to 3.10.4.
    - [Release notes](https://github.com/diffplug/spotless/releases)
    - [Changelog](https://github.com/diffplug/spotless/blob/main/CHANGES.md)
    - [Commits](https://github.com/diffplug/spotless/compare/maven/3.8.0...maven/3.10.4)
    
    ---
    updated-dependencies:
    - dependency-name: com.diffplug.spotless:spotless-maven-plugin
      dependency-version: 3.1.0
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <su...@github.com>
    
    * Apply spotless formatting
    
    Co-authored-by: Isaac <no...@databricks.com>
    
    ---------
    
    Signed-off-by: dependabot[bot] <su...@github.com>
    Co-authored-by: dependabot[bot] <49...@users.noreply.github.com>
    Co-authored-by: Fokko Driesprong <fo...@apache.org>
    Co-authored-by: Isaac <no...@databricks.com>
---
 .../parquet/variant/VariantBuilderBenchmark.java   | 46 +++++++++++++---------
 .../parquet/hadoop/ColumnIndexValidator.java       | 14 ++++---
 .../parquet/hadoop/rewrite/RewriteOptions.java     |  5 ++-
 pom.xml                                            |  2 +-
 4 files changed, 40 insertions(+), 27 deletions(-)

diff --git a/parquet-benchmarks/src/main/java/org/apache/parquet/variant/VariantBuilderBenchmark.java b/parquet-benchmarks/src/main/java/org/apache/parquet/variant/VariantBuilderBenchmark.java
index 65a000d82..d3e4c7d33 100644
--- a/parquet-benchmarks/src/main/java/org/apache/parquet/variant/VariantBuilderBenchmark.java
+++ b/parquet-benchmarks/src/main/java/org/apache/parquet/variant/VariantBuilderBenchmark.java
@@ -159,24 +159,34 @@ public class VariantBuilderBenchmark {
    * the variant builder and (b) add the type to a GroupBuilder.
    */
   private enum FieldType {
-    String((o, builder) -> builder.appendString(((String) o) + count()), b -> b.optional(PrimitiveTypeName.BINARY)
-        .as(LogicalTypeAnnotation.stringType())
-        .named("typed_value")),
-    Int((o, builder) -> builder.appendInt((Integer) o), b -> b.optional(PrimitiveTypeName.INT32)
-        .named("typed_value")),
-    Long((o, builder) -> builder.appendLong((Long) o), b -> b.optional(PrimitiveTypeName.INT64)
-        .named("typed_value")),
-    Float((o, builder) -> builder.appendFloat((Float) o), b -> b.optional(PrimitiveTypeName.FLOAT)
-        .named("typed_value")),
-    Double((o, builder) -> builder.appendDouble((Double) o), b -> b.optional(PrimitiveTypeName.DOUBLE)
-        .named("typed_value")),
-    BigDecimal((o, builder) -> builder.appendDecimal((BigDecimal) o), b -> b.optional(PrimitiveTypeName.INT32)
-        .as(LogicalTypeAnnotation.decimalType(0, 9))
-        .named("typed_value")),
-    UUID((o, builder) -> builder.appendUUID((UUID) o), b -> b.optional(PrimitiveTypeName.FIXED_LEN_BYTE_ARRAY)
-        .length(16)
-        .as(LogicalTypeAnnotation.uuidType())
-        .named("typed_value")),
+    String(
+        (o, builder) -> builder.appendString(((String) o) + count()),
+        b -> b.optional(PrimitiveTypeName.BINARY)
+            .as(LogicalTypeAnnotation.stringType())
+            .named("typed_value")),
+    Int(
+        (o, builder) -> builder.appendInt((Integer) o),
+        b -> b.optional(PrimitiveTypeName.INT32).named("typed_value")),
+    Long(
+        (o, builder) -> builder.appendLong((Long) o),
+        b -> b.optional(PrimitiveTypeName.INT64).named("typed_value")),
+    Float(
+        (o, builder) -> builder.appendFloat((Float) o),
+        b -> b.optional(PrimitiveTypeName.FLOAT).named("typed_value")),
+    Double(
+        (o, builder) -> builder.appendDouble((Double) o),
+        b -> b.optional(PrimitiveTypeName.DOUBLE).named("typed_value")),
+    BigDecimal(
+        (o, builder) -> builder.appendDecimal((BigDecimal) o),
+        b -> b.optional(PrimitiveTypeName.INT32)
+            .as(LogicalTypeAnnotation.decimalType(0, 9))
+            .named("typed_value")),
+    UUID(
+        (o, builder) -> builder.appendUUID((UUID) o),
+        b -> b.optional(PrimitiveTypeName.FIXED_LEN_BYTE_ARRAY)
+            .length(16)
+            .as(LogicalTypeAnnotation.uuidType())
+            .named("typed_value")),
     /** Nested MUST be the last in the enum. */
     Nested(
         (o, builder) -> {
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnIndexValidator.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnIndexValidator.java
index 5142506d2..b722ce394 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnIndexValidator.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnIndexValidator.java
@@ -460,12 +460,14 @@ public class ColumnIndexValidator {
 
       if (isNullPage) {
         // By specification null pages have empty byte arrays as min/max values
-        validateContract(!minValue.hasRemaining(), NULL_PAGE_HAS_NO_MIN, () -> statValueBuilder
-            .build(minValue)
-            .toString());
-        validateContract(!maxValue.hasRemaining(), NULL_PAGE_HAS_NO_MAX, () -> statValueBuilder
-            .build(maxValue)
-            .toString());
+        validateContract(
+            !minValue.hasRemaining(),
+            NULL_PAGE_HAS_NO_MIN,
+            () -> statValueBuilder.build(minValue).toString());
+        validateContract(
+            !maxValue.hasRemaining(),
+            NULL_PAGE_HAS_NO_MAX,
+            () -> statValueBuilder.build(maxValue).toString());
       } else if (prevMinValue != null) {
         validateBoundaryOrder(
             statValueBuilder.build(prevMinValue), statValueBuilder.build(prevMaxValue), boundaryOrder);
diff --git a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java
index f85b65ea3..d6c9aeb1e 100644
--- a/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java
+++ b/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java
@@ -587,8 +587,9 @@ public class RewriteOptions {
           renameColumns == null
               ? new HashMap<>()
               : renameColumns.entrySet().stream()
-                  .collect(Collectors.toMap(x -> x.getKey().trim(), x -> x.getValue()
-                      .trim())),
+                  .collect(Collectors.toMap(
+                      x -> x.getKey().trim(),
+                      x -> x.getValue().trim())),
           encryptColumns,
           fileEncryptionProperties,
           indexCacheStrategy,
diff --git a/pom.xml b/pom.xml
index 57da5e54a..f887b819a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -80,7 +80,7 @@
     <jackson-annotations.version>2.22</jackson-annotations.version>
     <japicmp.version>0.26.5</japicmp.version>
     <javax.annotation.version>1.3.2</javax.annotation.version>
-    <spotless.version>3.8.0</spotless.version>
+    <spotless.version>3.10.4</spotless.version>
     <shade.prefix>shaded.parquet</shade.prefix>
     <!-- Guarantees no newer classes/methods/constants are used by parquet. -->
     <hadoop.version>3.3.0</hadoop.version>