[GitHub] [pulsar] congbobo184 commented on a diff in pull request #17777: [fix][txn] optimize the ack/send future in TransactionImpl

[GitBox <gi...@apache.org>]

congbobo184 commented on code in PR #17777:
URL: https://github.com/apache/pulsar/pull/17777#discussion_r979200390


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionImpl.java:
##########
@@ -123,8 +132,25 @@ public CompletableFuture<Void> registerProducedTopic(String topic) {
         return completableFuture;
     }
 
-    public synchronized void registerSendOp(CompletableFuture<MessageId> sendFuture) {
-        sendFutureList.add(sendFuture);
+    public void registerSendOp(CompletableFuture<MessageId> newSendFuture) {
+        sendLock.lock();
+        try {
+            if (sendCount.getAndIncrement() == 0) {
+                sendFuture = new CompletableFuture<>();
+            }
+        } finally {
+            sendLock.unlock();
+        }
+        newSendFuture.thenRun(() -> {
+            sendLock.lock();

Review Comment:
   why do we need this lock?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org