[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1355: feat: support webhook validate plugin

["AlinsRan (via GitHub)" <gi...@apache.org>]

AlinsRan commented on code in PR #1355:
URL: https://github.com/apache/apisix-ingress-controller/pull/1355#discussion_r1160366016


##########
test/e2e/scaffold/scaffold.go:
##########
@@ -637,19 +634,6 @@ func waitExponentialBackoff(condFunc func() (bool, error)) error {
 	return wait.ExponentialBackoff(backoff, condFunc)
 }
 
-// generateWebhookCert generates signed certs of webhook and create the corresponding secret by running a script.
-func generateWebhookCert(ns string) error {
-	commandTemplate := `testdata/webhook-create-signed-cert.sh`

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org