You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2018/10/02 16:14:13 UTC

[GitHub] nicolaferraro closed pull request #149: chore: compile integration tests on make

nicolaferraro closed pull request #149: chore: compile integration tests on make
URL: https://github.com/apache/camel-k/pull/149
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/build/Makefile b/build/Makefile
index b67d95b4..5de8da8d 100644
--- a/build/Makefile
+++ b/build/Makefile
@@ -1,4 +1,4 @@
-build: build-runtime build-operator build-kamel test
+build: build-runtime build-operator build-kamel build-compile-integration-tests test
 
 build-operator: build-embed-resources
 	go build -o camel-k-operator ./cmd/camel-k-operator/*.go
@@ -9,6 +9,9 @@ build-kamel:
 build-embed-resources:
 	./build/embed_resources.sh deploy
 
+build-compile-integration-tests:
+	go test -run xxxxx -tags=integration ./test/*.go
+
 build-runtime:
 	./mvnw clean install -f ./runtime/pom.xml
 
diff --git a/test/build_manager_integration_test.go b/test/build_manager_integration_test.go
index fa7d8f8b..b7124f24 100644
--- a/test/build_manager_integration_test.go
+++ b/test/build_manager_integration_test.go
@@ -24,6 +24,7 @@ package test
 import (
 	"context"
 	"github.com/apache/camel-k/pkg/build/assemble"
+	"github.com/apache/camel-k/pkg/build/packager"
 	"github.com/apache/camel-k/pkg/build/publish"
 	"testing"
 	"time"
@@ -37,8 +38,9 @@ func TestBuildManagerBuild(t *testing.T) {
 	ctx := context.TODO()
 	namespace := getTargetNamespace()
 	assembler := assemble.NewMavenAssembler(ctx)
+	pack := packager.NewJavaStandardPackager(ctx)
 	publisher := publish.NewS2IPublisher(ctx, namespace)
-	buildManager := build.NewManager(ctx, assembler, publisher)
+	buildManager := build.NewManager(ctx, assembler, pack, publisher)
 	identifier := build.Identifier{
 		Name:      "man-test",
 		Qualifier: digest.Random(),
@@ -74,8 +76,9 @@ func TestBuildManagerFailedBuild(t *testing.T) {
 	ctx := context.TODO()
 	namespace := getTargetNamespace()
 	assembler := assemble.NewMavenAssembler(ctx)
+	pack := packager.NewJavaStandardPackager(ctx)
 	publisher := publish.NewS2IPublisher(ctx, namespace)
-	buildManager := build.NewManager(ctx, assembler, publisher)
+	buildManager := build.NewManager(ctx, assembler, pack, publisher)
 	identifier := build.Identifier{
 		Name:      "man-test-2",
 		Qualifier: digest.Random(),


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services