You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/14 03:11:41 UTC
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15433
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
[java] use KuduTestHarness in TestSecurity
Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
2 files changed, 79 insertions(+), 86 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/15433/1
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 )
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
Patch Set 4:
It would probably be good to rebase this before merging.
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 29 Apr 2020 17:08:44 +0000
Gerrit-HasComments: No
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 )
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15433/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/15433/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@78
PS1, Line 78: cla = new CapturingLogAppender();
Given it's not used in every test, maybe just instantiate the appender in the tests where it's used?
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 18 Mar 2020 22:01:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 )
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 21:30:03 +0000
Gerrit-HasComments: No
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 )
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
Patch Set 1:
Looks a bit odd: TestSecurity failed only under TSAN build. I'll take a closer look.
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 14 Mar 2020 03:44:41 +0000
Gerrit-HasComments: No
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 )
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15433/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/15433/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@438
PS4, Line 438: //for (HostAndPort hp : miniCluster.getMasterServers()) {
Nit: remove?
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 28 Apr 2020 23:17:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15433
to look at the new patch set (#3).
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
[java] use KuduTestHarness in TestSecurity
Updated TestSecurity to use KuduTestHarness. Fixed flakiness in the
testRenewAndReacquireKerberosCredentials scenario: the flakiness was
the most pronounced in TSAN builds when it takes longer to bootstrap
a test cluster.
Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
2 files changed, 90 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/15433/3
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15433
to look at the new patch set (#2).
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
[java] use KuduTestHarness in TestSecurity
Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/KuduTestHarness.java
2 files changed, 82 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/15433/2
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] use KuduTestHarness in TestSecurity
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 )
Change subject: [java] use KuduTestHarness in TestSecurity
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15433/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/15433/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@78
PS1, Line 78: cla = new CapturingLogAppender();
> Given it's not used in every test, maybe just instantiate the appender in t
Done
--
To view, visit http://gerrit.cloudera.org:8080/15433
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311
Gerrit-Change-Number: 15433
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Mar 2020 01:04:14 +0000
Gerrit-HasComments: Yes