[groovy] branch master updated: Include `Log4j2Test` (disable failing test cases for now)

[su...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new 5495aca  Include `Log4j2Test` (disable failing test cases for now)
5495aca is described below

commit 5495aca7b46fcbdcf7b6bb15ad5a05b053440eec
Author: Daniel Sun <su...@apache.org>
AuthorDate: Sat Apr 25 12:58:52 2020 +0800

    Include `Log4j2Test` (disable failing test cases for now)
---
 gradle/test.gradle                             | 3 ---
 src/test/groovy/util/logging/Log4j2Test.groovy | 6 ++++++
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/gradle/test.gradle b/gradle/test.gradle
index 603fd3c..25471c5 100644
--- a/gradle/test.gradle
+++ b/gradle/test.gradle
@@ -96,9 +96,6 @@ def buildExcludeFilter(boolean legacyTestSuite) {
         excludes << 'groovy/grape/'
     }
 
-    // tests not passing with indy : investigation required!
-    excludes += ['Log4j2Test']
-
     return { f ->
         excludes.any { f.file =~ it }
     }
diff --git a/src/test/groovy/util/logging/Log4j2Test.groovy b/src/test/groovy/util/logging/Log4j2Test.groovy
index b2003fc..045c5ef 100644
--- a/src/test/groovy/util/logging/Log4j2Test.groovy
+++ b/src/test/groovy/util/logging/Log4j2Test.groovy
@@ -19,6 +19,7 @@
 package groovy.util.logging
 
 import groovy.test.GroovyTestCase
+import groovy.test.NotYetImplemented
 
 import java.lang.reflect.Field
 import java.lang.reflect.Modifier
@@ -205,6 +206,7 @@ class Log4j2Test extends GroovyTestCase {
         }
     }
 
+    @NotYetImplemented
     void testLogInfo() {
         Class clazz = new GroovyClassLoader().parseClass('''
             @groovy.util.logging.Log4j2
@@ -240,6 +242,7 @@ class Log4j2Test extends GroovyTestCase {
         assert events[ind].message == "trace called"
     }
 
+    @NotYetImplemented
     void testLogFromStaticMethods() {
         Class clazz = new GroovyClassLoader().parseClass("""
             @groovy.util.logging.Log4j2
@@ -258,6 +261,7 @@ class Log4j2Test extends GroovyTestCase {
         assert events[0].message == "(static) info called"
     }
 
+    @NotYetImplemented
     void testLogInfoForNamedLogger() {
         Class clazz = new GroovyClassLoader().parseClass('''
             @groovy.util.logging.Log4j2('logger')
@@ -319,6 +323,7 @@ class Log4j2Test extends GroovyTestCase {
         assert appender.isLogGuarded == true
     }
 
+    @NotYetImplemented
     void testDefaultCategory() {
         Class clazz = new GroovyClassLoader().parseClass("""
                 @groovy.util.logging.Log4j2
@@ -333,6 +338,7 @@ class Log4j2Test extends GroovyTestCase {
         assert appender.getEvents().size() == 1
     }
 
+    @NotYetImplemented
     void testCustomCategory() {
         PatternLayout layout = createLayout('%m', Charset.forName('UTF-8'))
         Log4j2InterceptingAppender appenderForCustomCategory = new Log4j2InterceptingAppender('Appender4CustomCategory', null, layout)