[GitHub] [airflow] hussein-awala commented on a diff in pull request #33452: make `conf.set` case insensitive

["hussein-awala (via GitHub)" <gi...@apache.org>]

hussein-awala commented on code in PR #33452:
URL: https://github.com/apache/airflow/pull/33452#discussion_r1297748824


##########
airflow/configuration.py:
##########
@@ -1307,6 +1307,16 @@ def has_option(self, section: str, option: str) -> bool:
         except (NoOptionError, NoSectionError):
             return False
 
+    def set(self, section: str, option: str, value: str | None = None) -> None:
+        """
+        Set an option to the given value.
+
+        This override just makes sure the section and option are lower case, to match what we do in `get`.
+        """
+        section = str(section).lower()
+        option = str(option).lower()
+        super().set(section, option, value)

Review Comment:
   > Is this potentially a breaking change?
   
   For me this is a bugfix, because when we set some configurations with uppercase characters, they will be inaccessible through the get method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org