You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/18 17:19:56 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #5264: sched: Define SMP_NCPUS to 1 in no SMP case

gustavonihei commented on a change in pull request #5264:
URL: https://github.com/apache/incubator-nuttx/pull/5264#discussion_r786986988



##########
File path: arch/xtensa/src/esp32/esp32_irq.c
##########
@@ -595,11 +580,7 @@ void up_enable_irq(int irq)
   int cpuint = IRQ_GETCPUINT(g_irqmap[irq]);
 
   DEBUGASSERT(cpuint >= 0 && cpuint <= ESP32_CPUINT_MAX);
-#ifdef CONFIG_SMP
   DEBUGASSERT(cpu >= 0 && cpu <= CONFIG_SMP_NCPUS);

Review comment:
       ```suggestion
     DEBUGASSERT(cpu >= 0 && cpu < CONFIG_SMP_NCPUS);
   ```
   Not related to the change proposed in this PR, but since `cpu` is the CPU ID, it can't be equal to 1 in a single CPU scenario.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org