You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2013/01/09 14:08:13 UTC
svn commit: r1430835 -
/lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryDocValuesFormat.java
Author: rmuir
Date: Wed Jan 9 13:08:13 2013
New Revision: 1430835
URL: http://svn.apache.org/viewvc?rev=1430835&view=rev
Log:
more nocommits
Modified:
lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryDocValuesFormat.java
Modified: lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryDocValuesFormat.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryDocValuesFormat.java?rev=1430835&r1=1430834&r2=1430835&view=diff
==============================================================================
--- lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryDocValuesFormat.java (original)
+++ lucene/dev/branches/lucene4547/lucene/codecs/src/java/org/apache/lucene/codecs/memory/MemoryDocValuesFormat.java Wed Jan 9 13:08:13 2013
@@ -36,6 +36,7 @@ import org.apache.lucene.util.packed.Pac
/** Indexes doc values to disk and loads them in RAM at
* search time. */
+// nocommit: nuke this wrapper and just make a nice impl (e.g. FST for sortedbytes)
public class MemoryDocValuesFormat extends SimpleDocValuesFormat {
public MemoryDocValuesFormat() {
@@ -48,6 +49,9 @@ public class MemoryDocValuesFormat exten
return new SimpleTextDocValuesWriter(state, "dat");
}
+ // nocommit the get's of this thing need to use a map. its returning new ram instances
+ // per-thread!
+
@Override
public SimpleDVProducer fieldsProducer(SegmentReadState state) throws IOException {
final SimpleDVProducer producer = new SimpleTextDocValuesReader(state, "dat");
@@ -165,12 +169,6 @@ public class MemoryDocValuesFormat exten
}
@Override
- public SimpleDVProducer clone() {
- // We are already thread-safe:
- return this;
- }
-
- @Override
public void close() throws IOException {
producer.close();
}