You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/08/16 03:29:56 UTC
[GitHub] codecov-io edited a comment on issue #416: SCB-848 Uses zap to
replace the paas-lager
codecov-io edited a comment on issue #416: SCB-848 Uses zap to replace the paas-lager
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/416#issuecomment-413284340
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=h1) Report
> Merging [#416](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/447a47ad72afbcca2c175701bd8d57cb068b734d?src=pr&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `61.5%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
- Coverage 73.2% 73.09% -0.12%
==========================================
Files 124 126 +2
Lines 9917 9901 -16
==========================================
- Hits 7260 7237 -23
- Misses 2180 2183 +3
- Partials 477 481 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `61.11% <ø> (-7.08%)` | :arrow_down: |
| [pkg/util/reflect.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL3V0aWwvcmVmbGVjdC5nbw==) | `78.68% <ø> (ø)` | :arrow_up: |
| [server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv) | `50% <0%> (ø)` | :arrow_up: |
| [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (ø)` | |
| [server/govern/controller\_v4.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9jb250cm9sbGVyX3Y0Lmdv) | `73.49% <0%> (ø)` | :arrow_up: |
| [server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=) | `84.48% <0%> (ø)` | :arrow_up: |
| [server/plugin/infra/tracing/buildin/buildin.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vYnVpbGRpbi5nbw==) | `86% <0%> (ø)` | :arrow_up: |
| [server/core/backend/backend.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9iYWNrZW5kLmdv) | `34.88% <0%> (ø)` | :arrow_up: |
| [server/service/util/domain\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kb21haW5fdXRpbC5nbw==) | `61.19% <0%> (ø)` | :arrow_up: |
| [server/service/util/microservice\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9taWNyb3NlcnZpY2VfdXRpbC5nbw==) | `66.03% <0%> (ø)` | :arrow_up: |
| ... and [63 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=footer). Last update [447a47a...c660ead](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/416?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services