You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/17 20:16:48 UTC
[GitHub] [netbeans] blackleg opened a new pull request #1953: Test
SimpleNotificationDisplayer implementation
blackleg opened a new pull request #1953: Test SimpleNotificationDisplayer implementation
URL: https://github.com/apache/netbeans/pull/1953
Add test for SimpleNotificationDisplayer implementation and resolve some warnings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] blackleg commented on a change in pull request #1953:
Test SimpleNotificationDisplayer implementation
Posted by GitBox <gi...@apache.org>.
blackleg commented on a change in pull request #1953: Test SimpleNotificationDisplayer implementation
URL: https://github.com/apache/netbeans/pull/1953#discussion_r386107533
##########
File path: platform/openide.awt/test/unit/src/org/openide/awt/NotificationDisplayerTest.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.openide.awt;
+
+import java.util.HashMap;
+import java.util.Map;
+import javax.swing.JComponent;
+import org.junit.Test;
+import org.netbeans.junit.NbTestCase;
+import org.openide.awt.NotificationDisplayer.Category;
+import org.openide.awt.NotificationDisplayer.Priority;
+
+/**
+ *
+ * @author Hector Espert
+ */
+public class NotificationDisplayerTest extends NbTestCase {
+
+ private NotificationDisplayer notificationDisplayer;
+
+ public NotificationDisplayerTest(String name) {
+ super(name);
+ }
+
+ @Override
+ public void setUp() {
+ notificationDisplayer = NotificationDisplayer.getDefault();
+ assertNotNull(notificationDisplayer);
+ assertEquals("SimpleNotificationDisplayer", notificationDisplayer.getClass().getSimpleName());
Review comment:
> Should we make assumptions about which NotificationDisplayer is the default? That's not specified by the API.
It doesn't assume that `SimpleNotificationDisplayer` is the default NotificationDisplayer, only is for testing that if any other is not present, fallback implementation is loaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1953:
Test SimpleNotificationDisplayer implementation
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1953: Test SimpleNotificationDisplayer implementation
URL: https://github.com/apache/netbeans/pull/1953#discussion_r386042229
##########
File path: platform/openide.awt/test/unit/src/org/openide/awt/NotificationDisplayerTest.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.openide.awt;
+
+import java.util.HashMap;
+import java.util.Map;
+import javax.swing.JComponent;
+import org.junit.Test;
+import org.netbeans.junit.NbTestCase;
+import org.openide.awt.NotificationDisplayer.Category;
+import org.openide.awt.NotificationDisplayer.Priority;
+
+/**
+ *
+ * @author Hector Espert
+ */
+public class NotificationDisplayerTest extends NbTestCase {
+
+ private NotificationDisplayer notificationDisplayer;
+
+ public NotificationDisplayerTest(String name) {
+ super(name);
+ }
+
+ @Override
+ public void setUp() {
+ notificationDisplayer = NotificationDisplayer.getDefault();
+ assertNotNull(notificationDisplayer);
+ assertEquals("SimpleNotificationDisplayer", notificationDisplayer.getClass().getSimpleName());
Review comment:
Should we make assumptions about which NotificationDisplayer is the default? That's not specified by the API.
Are these tests that should pass for _any_ implementation of NotificationDisplayer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1953:
Test SimpleNotificationDisplayer implementation
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1953: Test SimpleNotificationDisplayer implementation
URL: https://github.com/apache/netbeans/pull/1953#discussion_r386042120
##########
File path: platform/openide.awt/test/unit/src/org/openide/awt/NotificationDisplayerTest.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.openide.awt;
+
+import java.util.HashMap;
+import java.util.Map;
+import javax.swing.JComponent;
+import org.junit.Test;
+import org.netbeans.junit.NbTestCase;
+import org.openide.awt.NotificationDisplayer.Category;
+import org.openide.awt.NotificationDisplayer.Priority;
+
+/**
+ *
+ * @author Hector Espert
+ */
+public class NotificationDisplayerTest extends NbTestCase {
Review comment:
Maybe rename to SimpleNotificationDisplayerTest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1953:
Test SimpleNotificationDisplayer implementation
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1953: Test SimpleNotificationDisplayer implementation
URL: https://github.com/apache/netbeans/pull/1953#discussion_r386042261
##########
File path: platform/openide.awt/test/unit/src/org/openide/awt/NotificationDisplayerTest.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.openide.awt;
+
+import java.util.HashMap;
+import java.util.Map;
+import javax.swing.JComponent;
+import org.junit.Test;
+import org.netbeans.junit.NbTestCase;
+import org.openide.awt.NotificationDisplayer.Category;
+import org.openide.awt.NotificationDisplayer.Priority;
+
+/**
+ *
+ * @author Hector Espert
+ */
+public class NotificationDisplayerTest extends NbTestCase {
+
+ private NotificationDisplayer notificationDisplayer;
+
+ public NotificationDisplayerTest(String name) {
+ super(name);
+ }
+
+ @Override
+ public void setUp() {
+ notificationDisplayer = NotificationDisplayer.getDefault();
+ assertNotNull(notificationDisplayer);
+ assertEquals("SimpleNotificationDisplayer", notificationDisplayer.getClass().getSimpleName());
+ }
+
+ @Test
+ public void testNotify_4args() {
+ Notification notification = notificationDisplayer.notify("title", null, "details", null);
+ assertNotNull(notification);
+ assertEquals("NotificationImpl", notification.getClass().getSimpleName());
Review comment:
That's an implementation detail--ideally the tests should not break if you change the implementation while following the API specs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a change in pull request #1953:
Test SimpleNotificationDisplayer implementation
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1953: Test SimpleNotificationDisplayer implementation
URL: https://github.com/apache/netbeans/pull/1953#discussion_r386042329
##########
File path: platform/openide.awt/test/unit/src/org/openide/awt/NotificationDisplayerTest.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.openide.awt;
+
+import java.util.HashMap;
+import java.util.Map;
+import javax.swing.JComponent;
+import org.junit.Test;
+import org.netbeans.junit.NbTestCase;
+import org.openide.awt.NotificationDisplayer.Category;
+import org.openide.awt.NotificationDisplayer.Priority;
+
+/**
+ *
+ * @author Hector Espert
+ */
+public class NotificationDisplayerTest extends NbTestCase {
+
+ private NotificationDisplayer notificationDisplayer;
+
+ public NotificationDisplayerTest(String name) {
+ super(name);
+ }
+
+ @Override
+ public void setUp() {
+ notificationDisplayer = NotificationDisplayer.getDefault();
+ assertNotNull(notificationDisplayer);
+ assertEquals("SimpleNotificationDisplayer", notificationDisplayer.getClass().getSimpleName());
+ }
+
+ @Test
+ public void testNotify_4args() {
+ Notification notification = notificationDisplayer.notify("title", null, "details", null);
+ assertNotNull(notification);
+ assertEquals("NotificationImpl", notification.getClass().getSimpleName());
+ assertEquals("title - details", StatusDisplayer.getDefault().getStatusText());
+ }
+
+ @Test
+ public void testNotify_5args_1() {
+ Notification notification = notificationDisplayer.notify("title", null, "details", null, Priority.LOW);
+ assertNotNull(notification);
+ assertEquals("NotificationImpl", notification.getClass().getSimpleName());
+ assertEquals("title - details", StatusDisplayer.getDefault().getStatusText());
+ }
+
+ @Test
+ public void testNotify_6args_1() {
+ Notification notification = notificationDisplayer.notify("title", null, "details", null, Priority.LOW, Category.ERROR);
+ assertNotNull(notification);
+ assertEquals("NotificationImpl", notification.getClass().getSimpleName());
+ assertEquals("title - details", StatusDisplayer.getDefault().getStatusText());
+ }
+
+ @Test
+ public void testNotify_6args_2() {
+ Notification notification = notificationDisplayer.notify("title", null, "details", null, Priority.LOW, "default_category_error");
+ assertNotNull(notification);
+ assertEquals("NotificationImpl", notification.getClass().getSimpleName());
+ assertEquals("title - details", StatusDisplayer.getDefault().getStatusText());
+ }
+
+ @Test
+ public void testNotify_5args_2() {
+ Notification notification = notificationDisplayer.notify("title", null, (JComponent)null, (JComponent)null, Priority.LOW);
+ assertNotNull(notification);
+ assertEquals("NotificationImpl", notification.getClass().getSimpleName());
+ assertEquals("title", StatusDisplayer.getDefault().getStatusText());
+ }
+
+ @Test
+ public void testNotify_6args_3() {
+ Notification notification = notificationDisplayer.notify("title", null, (JComponent)null, (JComponent)null, Priority.LOW, Category.ERROR);
+ assertNotNull(notification);
+ assertEquals("NotificationImpl", notification.getClass().getSimpleName());
+ assertEquals("title", StatusDisplayer.getDefault().getStatusText());
+ }
+
+ @Test
+ public void testNotify_6args_4() {
+ Notification notification = notificationDisplayer.notify("title", null, (JComponent)null, (JComponent)null, Priority.LOW, "default_category_error");
+ assertNotNull(notification);
+ assertEquals("NotificationImpl", notification.getClass().getSimpleName());
+ assertEquals("title", StatusDisplayer.getDefault().getStatusText());
Review comment:
These tests are repetitive--maybe factor out into a single testNotify(String expectedTitle, Notification notification) method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists