You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/14 11:43:28 UTC

[GitHub] [incubator-shardingsphere] TaoZhiMLND opened a new pull request #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm

TaoZhiMLND opened a new pull request #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5182
 
 
   Fixes #5168.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5182#issuecomment-613419497
 
 
   ## Pull Request Test Coverage Report for [Build 11042](https://coveralls.io/builds/30065057)
   
   * **17** of **18**   **(94.44%)**  changed or added relevant lines in **3** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.02%**) to **57.552%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-namespace/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/namespace/parser/KeyGenerateAlgorithmBeanDefinitionParser.java](https://coveralls.io/builds/30065057/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-namespace%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fnamespace%2Fparser%2FKeyGenerateAlgorithmBeanDefinitionParser.java#L46) | 9 | 10 | 90.0%
   <!-- | **Total:** | **17** | **18** | **94.44%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30065057/badge)](https://coveralls.io/builds/30065057) |
   | :-- | --: |
   | Change from base [Build 11039](https://coveralls.io/builds/30063880): |  0.02% |
   | Covered Lines: | 11850 |
   | Relevant Lines: | 20590 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5182#issuecomment-613418264
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=h1) Report
   > Merging [#5182](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/c68986cc4ad0214b204b2cc881f00a3f19eca085&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5182      +/-   ##
   ============================================
   + Coverage     54.08%   54.09%   +0.01%     
   - Complexity      402      404       +2     
   ============================================
     Files          1158     1160       +2     
     Lines         20574    20588      +14     
     Branches       3711     3712       +1     
   ============================================
   + Hits          11127    11138      +11     
   - Misses         8753     8754       +1     
   - Partials        694      696       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/factorybean/KeyGenerateAlgorithmFactoryBean.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vS2V5R2VuZXJhdGVBbGdvcml0aG1GYWN0b3J5QmVhbi5qYXZh) | `90.90% <80.00%> (-9.10%)` | `1.00 <0.00> (ø)` | |
   | [...rser/KeyGenerateAlgorithmBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0tleUdlbmVyYXRlQWxnb3JpdGhtQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `80.00% <80.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../spring/namespace/handler/SPINamespaceHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvaGFuZGxlci9TUElOYW1lc3BhY2VIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=footer). Last update [c68986c...1219db4](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm

Posted by GitBox <gi...@apache.org>.
cherrylzhao merged pull request #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5182
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5182#issuecomment-613418264
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=h1) Report
   > Merging [#5182](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/e76c277c7c441ceda3e7dbef23f7a06711282428&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5182      +/-   ##
   ============================================
   + Coverage     54.08%   54.10%   +0.01%     
   - Complexity      402      404       +2     
   ============================================
     Files          1158     1160       +2     
     Lines         20576    20590      +14     
     Branches       3712     3713       +1     
   ============================================
   + Hits          11129    11140      +11     
   - Misses         8753     8754       +1     
   - Partials        694      696       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/factorybean/KeyGenerateAlgorithmFactoryBean.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vS2V5R2VuZXJhdGVBbGdvcml0aG1GYWN0b3J5QmVhbi5qYXZh) | `90.90% <80.00%> (-9.10%)` | `1.00 <0.00> (ø)` | |
   | [...rser/KeyGenerateAlgorithmBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0tleUdlbmVyYXRlQWxnb3JpdGhtQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `80.00% <80.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [.../spring/namespace/handler/SPINamespaceHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nL3NoYXJkaW5nLWpkYmMtc3ByaW5nLW5hbWVzcGFjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdqZGJjL3NwcmluZy9uYW1lc3BhY2UvaGFuZGxlci9TUElOYW1lc3BhY2VIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=footer). Last update [e76c277...f6b20d1](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5182#issuecomment-613419497
 
 
   ## Pull Request Test Coverage Report for [Build 11047](https://coveralls.io/builds/30071790)
   
   * **17** of **18**   **(94.44%)**  changed or added relevant lines in **3** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.02%**) to **57.548%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-spring/sharding-jdbc-spring/sharding-jdbc-spring-namespace/src/main/java/org/apache/shardingsphere/shardingjdbc/spring/namespace/parser/KeyGenerateAlgorithmBeanDefinitionParser.java](https://coveralls.io/builds/30071790/source?filename=sharding-spring%2Fsharding-jdbc-spring%2Fsharding-jdbc-spring-namespace%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Fspring%2Fnamespace%2Fparser%2FKeyGenerateAlgorithmBeanDefinitionParser.java#L46) | 9 | 10 | 90.0%
   <!-- | **Total:** | **17** | **18** | **94.44%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30071790/badge)](https://coveralls.io/builds/30071790) |
   | :-- | --: |
   | Change from base [Build 11045](https://coveralls.io/builds/30067335): |  0.02% |
   | Covered Lines: | 11848 |
   | Relevant Lines: | 20588 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm

Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on issue #5182: add KeyGenerateAlgorithmBeanDefinitionParser to simplify the configuration API of KeyGenerateAlgorithm
URL: https://github.com/apache/incubator-shardingsphere/pull/5182#issuecomment-613466907
 
 
   good job! it looks good to me, please fix the conflict files

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services