You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2021/11/19 16:17:46 UTC
[GitHub] [lucenenet] NightOwl888 opened a new issue #549: Failing Test: Lucene.Net.Search.Join.TestJoinUtil::TestMultiValueRandomJoin()
NightOwl888 opened a new issue #549:
URL: https://github.com/apache/lucenenet/issues/549
> For information about how to help us debug tests, see #269.
This test only started failing after fixing the test framework to randomize the codecs, culture and time zone (NUnit's Randomizer was always initialized with a seed of 0, so none of these were actually random).
It only fails on .NET Framework under x86 on Windows, and only when optimizations are enabled (Release mode). I have confirmed that the test is 100% repeatable with the below seed and culture.
So far, all similar failures have been due to one of two things:
1. Floating point numbers are compared directly using `==`, `>=`, `<=`, `>`, or `<`. To fix these, converting the `float` data type to an `int` for both sides of the comparison has worked using `Lucene.Net.Util.NumericUtils.SingleToSortableInt32()`.
2. A `float` is being assigned to a `double`, which makes it change in precision. A place to watch out for are the `Math` functions that accept `double` as a parameter but are passed a `float`. For score values which can only be between 0 and 1, doing an intermediate cast to a `decimal` works (`double x = (double)(decimal)theFloat`). However, we haven't found a solution that works in more general cases because this could overflow the `decimal` for large numbers.
### Failure 1
```
Lucene.Net.Tests.Join - net48 - x86 - Windows | Tests failed: 1, passed: 69, ignored: 0TestMultiValueRandomJoin
Failed 8h ago on fv-az292-983
Duration0:00:00.763
Ownernot available
Date started11/19/2021, 3:10:28 PM
Date completed11/19/2021, 3:10:29 PM
Failing since8h ago
Failing since buildCurrent build
Expected: 5.5041933059692383d +/- 0.0d
But was: 5.5041937828063965d
Off by: -4.76837158203125E-07d
To reproduce this test result:
Option 1:
Apply the following assembly-level attributes:
[assembly: Lucene.Net.Util.RandomSeed(0x4ce16e9f591fde54L)]
[assembly: NUnit.Framework.SetCulture("sr-Cyrl-ME")]
Option 2:
Use the following .runsettings file:
<RunSettings>
<TestRunParameters>
<Parameter name="tests:seed" value="0x4ce16e9f591fde54" />
<Parameter name="tests:culture" value="sr-Cyrl-ME" />
</TestRunParameters>
</RunSettings>
See the .runsettings documentation at: https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file.
at Lucene.Net.Util.LuceneTestCase.assertEquals(Single d1, Single d2, Single delta) in D:\a\1\s\src\Lucene.Net.TestFramework\Support\JavaCompatibility\LuceneTestCase.cs:line 174
at Lucene.Net.Tests.Join.TestJoinUtil.ExecuteRandomJoin(Boolean multipleValuesPerDocument, Int32 maxIndexIter, Int32 maxSearchIter, Int32 numberOfDocumentsToIndex) in D:\a\1\s\src\Lucene.Net.Tests.Join\Support\TestJoinUtil.cs:line 504
at Lucene.Net.Tests.Join.TestJoinUtil.TestMultiValueRandomJoin() in D:\a\1\s\src\Lucene.Net.Tests.Join\Support\TestJoinUtil.cs:line 399
```
See: https://dev.azure.com/lucene-net-temp4/Main/_build/results?buildId=77&view=ms.vss-test-web.build-test-results-tab&runId=60166&resultId=100022&paneView=debug to download the test artifacts, but do note that the build will be cleaned up after 30 days.
### Failure 2
```
Lucene.Net.Tests.Join - net48 - x86 - Windows | Tests failed: 1, passed: 69, ignored: 0TestMultiValueRandomJoin
Failed 11h ago on WIN-VF2R71D3ST9
Duration0:00:02.167
Ownernot available
Date started11/19/2021, 12:18:29 PM
Date completed11/19/2021, 12:18:31 PM
Failing since11h ago
Failing since build4.8.0-ci0000001842
Expected: 3.7507178783416748d +/- 0.0d
But was: 3.7507176399230957d
Off by: 2.384185791015625E-07d
To reproduce this test result:
Option 1:
Apply the following assembly-level attributes:
[assembly: Lucene.Net.Util.RandomSeed(0xc9754874a855ec2aL)]
[assembly: NUnit.Framework.SetCulture("it-VA")]
Option 2:
Use the following .runsettings file:
<RunSettings>
<TestRunParameters>
<Parameter name="tests:seed" value="0xc9754874a855ec2a" />
<Parameter name="tests:culture" value="it-VA" />
</TestRunParameters>
</RunSettings>
See the .runsettings documentation at: https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file.
at Lucene.Net.Util.LuceneTestCase.assertEquals(Single d1, Single d2, Single delta) in D:\a\1\s\src\Lucene.Net.TestFramework\Support\JavaCompatibility\LuceneTestCase.cs:line 174
at Lucene.Net.Search.Join.TestJoinUtil.ExecuteRandomJoin(Boolean multipleValuesPerDocument, Int32 maxIndexIter, Int32 maxSearchIter, Int32 numberOfDocumentsToIndex) in D:\a\1\s\src\Lucene.Net.Tests.Join\TestJoinUtil.cs:line 501
at Lucene.Net.Search.Join.TestJoinUtil.TestMultiValueRandomJoin() in D:\a\1\s\src\Lucene.Net.Tests.Join\TestJoinUtil.cs:line 396
```
See: https://dev.azure.com/lucene-net-temp3/Lucene.NET/_build/results?buildId=593&view=ms.vss-test-web.build-test-results-tab&runId=432744&resultId=100024&paneView=debug to download the test artifacts, but do note that the build will be cleaned up after 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 closed issue #549: Failing Test: Lucene.Net.Search.Join.TestJoinUtil::TestMultiValueRandomJoin()
Posted by GitBox <gi...@apache.org>.
NightOwl888 closed issue #549:
URL: https://github.com/apache/lucenenet/issues/549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on issue #549: Failing Test: Lucene.Net.Search.Join.TestJoinUtil::TestMultiValueRandomJoin()
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on issue #549:
URL: https://github.com/apache/lucenenet/issues/549#issuecomment-987941110
Actually, I was able to rule a lot of stuff out right away because it only failed under rare circumstances, I was able to isolate it to the `Lucene.Net` assembly by disabling optimizations, and the actual number of calls into `Lucene.Net` were limited for this test. The part about *where* it was failing was a bit confusing, though - the method doing the actual float math was returning the correct value, but this intermediate method was truncating it when it returned.
That said, I haven't come up with a good explanation why casting fixes it but using `MethodImplOptons.NoOptimization` on this method and all methods that it calls does not fix it. But casting seems to make the jitter happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] rclabo commented on issue #549: Failing Test: Lucene.Net.Search.Join.TestJoinUtil::TestMultiValueRandomJoin()
Posted by GitBox <gi...@apache.org>.
rclabo commented on issue #549:
URL: https://github.com/apache/lucenenet/issues/549#issuecomment-987924867
Wow! You found one of the really hard bugs -- one that only fails in release mode with optimizations enabled. Wow -- Well done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org