You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2014/10/15 14:43:10 UTC
Review Request 26743: Admin View: Show confirmation dialog when
navigate from User/Group edit page.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26743/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
Bugs: AMBARI-7786
https://issues.apache.org/jira/browse/AMBARI-7786
Repository: ambari
Description
-------
When user trying to navigate from User/Group/Instance edit/create page - show confirmation dialog.
Cancel/discard/save
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/index.html f0f3f18
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js a9c3268
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js 1ff860a
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsCreateCtrl.js 7ee02c0
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js e91d4b7
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UnsavedDialog.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html eafd7d0
ambari-admin/src/main/resources/ui/admin-web/app/views/groups/create.html 9e3bc47
ambari-admin/src/main/resources/ui/admin-web/app/views/users/create.html 912a26d
ambari-admin/src/main/resources/ui/admin-web/test/unit/services/UnsavedDialog__test.js PRE-CREATION
Diff: https://reviews.apache.org/r/26743/diff/
Testing
-------
added 1 test
4583 tests complete (6 seconds)
60 tests pending
Thanks,
Andriy Babiichuk
Re: Review Request 26743: Admin View: Show confirmation dialog when
navigate from User/Group edit page.
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26743/#review56691
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 15, 2014, 12:43 після полудня, Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26743/
> -----------------------------------------------------------
>
> (Updated Жов. 15, 2014, 12:43 після полудня)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-7786
> https://issues.apache.org/jira/browse/AMBARI-7786
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When user trying to navigate from User/Group/Instance edit/create page - show confirmation dialog.
>
> Cancel/discard/save
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/index.html f0f3f18
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js a9c3268
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js 1ff860a
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsCreateCtrl.js 7ee02c0
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js e91d4b7
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UnsavedDialog.js PRE-CREATION
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html eafd7d0
> ambari-admin/src/main/resources/ui/admin-web/app/views/groups/create.html 9e3bc47
> ambari-admin/src/main/resources/ui/admin-web/app/views/users/create.html 912a26d
> ambari-admin/src/main/resources/ui/admin-web/test/unit/services/UnsavedDialog__test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26743/diff/
>
>
> Testing
> -------
>
> added 1 test
> 4583 tests complete (6 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>
Re: Review Request 26743: Admin View: Show confirmation dialog when
navigate from User/Group edit page.
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26743/#review56695
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Nechiporenko
On Oct. 15, 2014, 12:43 p.m., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26743/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 12:43 p.m.)
>
>
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-7786
> https://issues.apache.org/jira/browse/AMBARI-7786
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When user trying to navigate from User/Group/Instance edit/create page - show confirmation dialog.
>
> Cancel/discard/save
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/index.html f0f3f18
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js a9c3268
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js 1ff860a
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsCreateCtrl.js 7ee02c0
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js e91d4b7
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UnsavedDialog.js PRE-CREATION
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html eafd7d0
> ambari-admin/src/main/resources/ui/admin-web/app/views/groups/create.html 9e3bc47
> ambari-admin/src/main/resources/ui/admin-web/app/views/users/create.html 912a26d
> ambari-admin/src/main/resources/ui/admin-web/test/unit/services/UnsavedDialog__test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26743/diff/
>
>
> Testing
> -------
>
> added 1 test
> 4583 tests complete (6 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>
Re: Review Request 26743: Admin View: Show confirmation dialog when
navigate from User/Group edit page.
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26743/
-----------------------------------------------------------
(Updated Окт. 15, 2014, 1:11 п.п.)
Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
Bugs: AMBARI-7786
https://issues.apache.org/jira/browse/AMBARI-7786
Repository: ambari
Description
-------
When user trying to navigate from User/Group/Instance edit/create page - show confirmation dialog.
Cancel/discard/save
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/index.html f0f3f18
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js a9c3268
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js 1ff860a
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsCreateCtrl.js 7ee02c0
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersCreateCtrl.js e91d4b7
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UnsavedDialog.js PRE-CREATION
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html eafd7d0
ambari-admin/src/main/resources/ui/admin-web/app/views/groups/create.html 9e3bc47
ambari-admin/src/main/resources/ui/admin-web/app/views/users/create.html 912a26d
ambari-admin/src/main/resources/ui/admin-web/test/unit/services/UnsavedDialog__test.js PRE-CREATION
Diff: https://reviews.apache.org/r/26743/diff/
Testing (updated)
-------
added 1 test
Thanks,
Andriy Babiichuk