You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/29 23:08:10 UTC
[GitHub] [tvm] mehrdadh opened a new pull request, #11193: [ARM][Strategy] Fix is_int8_hw_support check function
mehrdadh opened a new pull request, #11193:
URL: https://github.com/apache/tvm/pull/11193
This PR fixes the `is_int8_hw_support` check function and adds few warning messages when unoptimized schedules are used for ARM targets.
cc @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #11193: [ARM][Strategy] Fix is_int8_hw_support check function
Posted by GitBox <gi...@apache.org>.
u99127 commented on PR #11193:
URL: https://github.com/apache/tvm/pull/11193#issuecomment-1116736847
Please add a test or 2 ... 😃
I'll be able to look at this later in the week.
Ramana.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #11193: [ARM][Strategy] Fix is_int8_hw_support check function
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #11193:
URL: https://github.com/apache/tvm/pull/11193#issuecomment-1117690590
@u99127 I have added a test. Also looks like there's a bug in [get_arch_version](https://github.com/apache/tvm/blob/3d0fc36ae4967a5ee24a75cff311828447003235/python/tvm/topi/arm_cpu/arm_utils.py#L24) because when I pass `-mattr=v8.4a,+dotprod` in the target, architecture is returned as `8.0` instead of `8.4`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #11193: [ARM][Strategy] Fix is_int8_hw_support check function
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #11193:
URL: https://github.com/apache/tvm/pull/11193#issuecomment-1122658426
@u99127 Friendly reminder about this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #11193: [ARM][Strategy] Fix is_int8_hw_support check function
Posted by GitBox <gi...@apache.org>.
u99127 commented on PR #11193:
URL: https://github.com/apache/tvm/pull/11193#issuecomment-1124347127
> @u99127 I have added a test. Also looks like there's a bug in [get_arch_version](https://github.com/apache/tvm/blob/3d0fc36ae4967a5ee24a75cff311828447003235/python/tvm/topi/arm_cpu/arm_utils.py#L24) because when I pass `-mattr=v8.4a,+dotprod` in the target, architecture is returned as `8.0` instead of `8.4`.
LGTM, I do think that needs to be fixed separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #11193: [ARM][Strategy] Fix is_int8_hw_support check function
Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #11193:
URL: https://github.com/apache/tvm/pull/11193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org