You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/15 01:26:04 UTC

[kudu-CR] raft consensus-itest: fix reliance on std::unordered map iteration order

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4422

Change subject: raft_consensus-itest: fix reliance on std::unordered_map iteration order
......................................................................

raft_consensus-itest: fix reliance on std::unordered_map iteration order

Fixes another instance similar to cb8f17589486 in which we were relying
on the iteration order of an unordered map. This caused the test to fail
in some environments.

Change-Id: Id6fd1391bfb1be0a67f66f73286e3c81127c5f26
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/4422/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6fd1391bfb1be0a67f66f73286e3c81127c5f26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>

[kudu-CR] raft consensus-itest: fix reliance on std::unordered map iteration order

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: raft_consensus-itest: fix reliance on std::unordered_map iteration order
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3430/

-- 
To view, visit http://gerrit.cloudera.org:8080/4422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6fd1391bfb1be0a67f66f73286e3c81127c5f26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] raft consensus-itest: fix reliance on std::unordered map iteration order

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: raft_consensus-itest: fix reliance on std::unordered_map iteration order
......................................................................


raft_consensus-itest: fix reliance on std::unordered_map iteration order

Fixes another instance similar to cb8f17589486 in which we were relying
on the iteration order of an unordered map. This caused the test to fail
in some environments.

Change-Id: Id6fd1391bfb1be0a67f66f73286e3c81127c5f26
Reviewed-on: http://gerrit.cloudera.org:8080/4422
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id6fd1391bfb1be0a67f66f73286e3c81127c5f26
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] raft consensus-itest: fix reliance on std::unordered map iteration order

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: raft_consensus-itest: fix reliance on std::unordered_map iteration order
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4422
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6fd1391bfb1be0a67f66f73286e3c81127c5f26
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No