[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1423: nimble/phy/nrf5x: Fix PA for tx-tx transition

[GitBox <gi...@apache.org>]

sjanc commented on code in PR #1423:
URL: https://github.com/apache/mynewt-nimble/pull/1423#discussion_r1056244315


##########
nimble/drivers/nrf5x/src/ble_phy.c:
##########
@@ -1096,6 +1096,11 @@ ble_phy_tx_end_isr(void)
         tx_time = NRF_TIMER0->CC[2] + tifs;
         /* Adjust for delay between EVENT_END and actual TX end time */
         tx_time += g_ble_phy_t_txenddelay[tx_phy_mode];
+
+#if PHY_USE_FEM_PA
+        fem_time = tx_time - MYNEWT_VAL(BLE_FEM_PA_TURN_ON_US);

Review Comment:
   fem_time should now be under if PHY_USE_FEM



##########
nimble/drivers/nrf5x/src/ble_phy.c:
##########
@@ -1096,6 +1096,11 @@ ble_phy_tx_end_isr(void)
         tx_time = NRF_TIMER0->CC[2] + tifs;
         /* Adjust for delay between EVENT_END and actual TX end time */
         tx_time += g_ble_phy_t_txenddelay[tx_phy_mode];
+
+#if PHY_USE_FEM_PA
+        fem_time = tx_time - MYNEWT_VAL(BLE_FEM_PA_TURN_ON_US);

Review Comment:
   fem_time should now be under #if PHY_USE_FEM



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org