You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/02/13 00:22:05 UTC
Review Request 65615: Added docker constants and common functions
file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
This patch is in preparation of porting docker tests to Windows. There
were a few hardcoded values that were used throughout the codebase,
such as the `alpine` image, that are defined as a constant in a single
file.
Diffs
-----
src/tests/containerizer/docker_common.hpp PRE-CREATION
src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
src/tests/mesos.hpp c5593c25dde18c005f195a1885a8586bc72c849f
Diff: https://reviews.apache.org/r/65615/diff/1/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 65615: Added docker constants and common functions
file.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review197343
-----------------------------------------------------------
src/tests/containerizer/docker_common.hpp
Lines 1-18 (patched)
<https://reviews.apache.org/r/65615/#comment277474>
Did this header get added to Autotools where necessary?
- Andrew Schwartzmeyer
On Feb. 12, 2018, 4:22 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 4:22 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp PRE-CREATION
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
> src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
> src/tests/mesos.hpp c5593c25dde18c005f195a1885a8586bc72c849f
>
>
> Diff: https://reviews.apache.org/r/65615/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65615: Added docker constants and common functions
file.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Feb. 22, 2018, 3:25 a.m., Alexander Rukletsov wrote:
> > src/Makefile.am
> > Lines 1276 (patched)
> > <https://reviews.apache.org/r/65615/diff/3/?file=1963325#file1963325line1276>
> >
> > What about CMake?
Headers are free in CMake.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review198108
-----------------------------------------------------------
On Feb. 21, 2018, 5:47 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2018, 5:47 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
>
>
> Diffs
> -----
>
> src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288
> src/tests/containerizer/docker_common.hpp PRE-CREATION
> src/tests/containerizer/docker_containerizer_tests.cpp 97335e197fb0fcb5caa06d8cea4a57277d2cf1f3
> src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
> src/tests/mesos.hpp 1416682fc8b51d38adc02d549a81fd0b09c83fa9
>
>
> Diff: https://reviews.apache.org/r/65615/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65615: Added docker constants and common functions
file.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review198108
-----------------------------------------------------------
To simplify reviewing, in the future please separate refactoring and moving stuff around from actual changes.
src/Makefile.am
Lines 1276 (patched)
<https://reviews.apache.org/r/65615/#comment278216>
What about CMake?
- Alexander Rukletsov
On Feb. 22, 2018, 1:47 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2018, 1:47 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
>
>
> Diffs
> -----
>
> src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288
> src/tests/containerizer/docker_common.hpp PRE-CREATION
> src/tests/containerizer/docker_containerizer_tests.cpp 97335e197fb0fcb5caa06d8cea4a57277d2cf1f3
> src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
> src/tests/mesos.hpp 1416682fc8b51d38adc02d549a81fd0b09c83fa9
>
>
> Diff: https://reviews.apache.org/r/65615/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65615: Added docker constants and common functions
file.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/
-----------------------------------------------------------
(Updated Feb. 22, 2018, 1:47 a.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
This patch is in preparation of porting docker tests to Windows. There
were a few hardcoded values that were used throughout the codebase,
such as the `alpine` image, that are defined as a constant in a single
file.
Diffs (updated)
-----
src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288
src/tests/containerizer/docker_common.hpp PRE-CREATION
src/tests/containerizer/docker_containerizer_tests.cpp 97335e197fb0fcb5caa06d8cea4a57277d2cf1f3
src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab
src/tests/mesos.hpp 1416682fc8b51d38adc02d549a81fd0b09c83fa9
Diff: https://reviews.apache.org/r/65615/diff/3/
Changes: https://reviews.apache.org/r/65615/diff/2-3/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 65615: Added docker constants and common functions
file.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review197703
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Feb. 16, 2018, 3:30 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2018, 3:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
>
>
> Diffs
> -----
>
> src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288
> src/tests/containerizer/docker_common.hpp PRE-CREATION
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
> src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
> src/tests/mesos.hpp f088cfdd490054ec605e33bd8c361a9d0939e22d
>
>
> Diff: https://reviews.apache.org/r/65615/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 65615: Added docker constants and common functions
file.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/
-----------------------------------------------------------
(Updated Feb. 16, 2018, 11:30 p.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.
Changes
-------
Address feedback
Bugs: MESOS-8498
https://issues.apache.org/jira/browse/MESOS-8498
Repository: mesos
Description
-------
This patch is in preparation of porting docker tests to Windows. There
were a few hardcoded values that were used throughout the codebase,
such as the `alpine` image, that are defined as a constant in a single
file.
Diffs (updated)
-----
src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288
src/tests/containerizer/docker_common.hpp PRE-CREATION
src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
src/tests/mesos.hpp f088cfdd490054ec605e33bd8c361a9d0939e22d
Diff: https://reviews.apache.org/r/65615/diff/2/
Changes: https://reviews.apache.org/r/65615/diff/1-2/
Testing
-------
Thanks,
Akash Gupta
Re: Review Request 65615: Added docker constants and common functions
file.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/#review197344
-----------------------------------------------------------
src/tests/containerizer/docker_common.hpp
Lines 126 (patched)
<https://reviews.apache.org/r/65615/#comment277475>
`status()->get()`
src/tests/containerizer/docker_common.hpp
Lines 163 (patched)
<https://reviews.apache.org/r/65615/#comment277476>
Ditto. Avoid chained .get()s.
- Andrew Schwartzmeyer
On Feb. 12, 2018, 4:22 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65615/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2018, 4:22 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-8498
> https://issues.apache.org/jira/browse/MESOS-8498
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is in preparation of porting docker tests to Windows. There
> were a few hardcoded values that were used throughout the codebase,
> such as the `alpine` image, that are defined as a constant in a single
> file.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp PRE-CREATION
> src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99
> src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d
> src/tests/mesos.hpp c5593c25dde18c005f195a1885a8586bc72c849f
>
>
> Diff: https://reviews.apache.org/r/65615/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>