You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/24 01:18:00 UTC

[GitHub] [incubator-hudi] modi95 opened a new pull request #1125: [HUDI-464] Use Hive Exec Core

modi95 opened a new pull request #1125: [HUDI-464] Use Hive Exec Core
URL: https://github.com/apache/incubator-hudi/pull/1125

## What is the purpose of the pull request

HUDI depends on `hive-exec` which contains a number of dependencies which have version conflicts with the dependencies required by Spark. Specifically, we are going to upgrade HUDI to `spark 2.4.4` which depends on `avro 1.8.2`, whereas `hive-exec` brings in `avro 1.7.7`.

We have run into many issues arising form the way that `hive-exec` packages its dependencies. To address these issues, we are choosing to move to `hive-exec:core` which does not include these dependencies.

## Brief change log

Change poms to use hive exec with the `core` classifier.

## Verify this pull request

Verified by ensuring spark and hive queries in https://hudi.apache.org/docker_demo.html#step-4-a-run-hive-queries continue to work as expected.

## Committer checklist

- [ ] Has a corresponding JIRA in PR title & commit

- [ ] Commit message is descriptive of the change

- [ ] CI is green

- [ ] Necessary doc changes done or have another open PR

- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1125: [HUDI-464] : Use Hive Exec Core

Posted by GitBox <gi...@apache.org>.

vinothchandar commented on a change in pull request #1125: [HUDI-464] : Use Hive Exec Core
URL: https://github.com/apache/incubator-hudi/pull/1125#discussion_r362260723
 
 

 ##########
 File path: hudi-client/pom.xml
 ##########
 @@ -231,6 +231,13 @@
       <artifactId>hive-exec</artifactId>
       <version>${hive.version}</version>
       <scope>test</scope>
 
 Review comment:
   but this was `test` scoped right.. so the issues you ran into were around running tests using spark 2.4.4? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] modi95 commented on a change in pull request #1125: [HUDI-464] : Use Hive Exec Core

Posted by GitBox <gi...@apache.org>.

modi95 commented on a change in pull request #1125: [HUDI-464] : Use Hive Exec Core
URL: https://github.com/apache/incubator-hudi/pull/1125#discussion_r363543757
 
 

 ##########
 File path: hudi-client/pom.xml
 ##########
 @@ -231,6 +231,13 @@
       <artifactId>hive-exec</artifactId>
       <version>${hive.version}</version>
       <scope>test</scope>
 
 Review comment:
   Yes - this is a fix to an issue that shows up only while running unit tests. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar merged pull request #1125: [HUDI-464] : Use Hive Exec Core

Posted by GitBox <gi...@apache.org>.

vinothchandar merged pull request #1125: [HUDI-464] : Use Hive Exec Core
URL: https://github.com/apache/incubator-hudi/pull/1125
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #1125: [HUDI-464] : Use Hive Exec Core

Posted by GitBox <gi...@apache.org>.

n3nash commented on a change in pull request #1125: [HUDI-464] : Use Hive Exec Core
URL: https://github.com/apache/incubator-hudi/pull/1125#discussion_r362993485
 
 

 ##########
 File path: hudi-client/pom.xml
 ##########
 @@ -231,6 +231,13 @@
       <artifactId>hive-exec</artifactId>
       <version>${hive.version}</version>
       <scope>test</scope>
 
 Review comment:
   Yes, the issues we faced was during running on tests.  @modi95 please confirm

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services