[GitHub] [cloudstack] weizhouapache commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

[GitBox <gi...@apache.org>]

weizhouapache commented on pull request #4200:
URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-901711561


   > @DaanHoogland I suppose either some arguments to answer the concerns - security or billing worries; or a global setting to toggle between the feature. For example, some test cases (either manually tested or a smoketests exists or is added):
   > 
   > * Can I as a domain admin create an offering without domain ID, but that offering is used by other accounts outside of the domain? What if I'm domain admin of a sub-domain; can the offering be used by accounts of parent domain?
   > * What are the scope of the offering/settings that domain admin can add, for ex. can I specify storage tag etc?
   > 
   > cc @ravening
   
   @rhtyd  @DaanHoogland @PaulAngus 
   cloudstack already allows domain admin to create service/disk offering since 2014
   (see commit "CLOUDSTACK-7983: Create Disk/Service Offering for Domain Admin")
   @shwstppr made some changes to support multiple domains/zones in 2019
   (see commit "server: changes for domain, zone specified service offerings")
   
   my opinion is, this is just an simple improvement of the feature.
   (1) as root admin, "create offering without domainid" = "create offering with domainid=<ROOT domain>"
   (2) as domain admin, "create offering without domainid" = "create offering with domainid=<domain id of account>"
   that's it. I do not see any risk.
   
   If you have concerns or objections on the feature, we can discuss in another thread.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org