You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2022/04/10 05:03:00 UTC
[jira] [Commented] (HBASE-26922) Fix LineLength warnings as much as possible if it can not be fixed by spotless
[ https://issues.apache.org/jira/browse/HBASE-26922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520072#comment-17520072 ]
Hudson commented on HBASE-26922:
--------------------------------
Results for branch branch-2
[build #512 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/512/]: (/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/512/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/512/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/512/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/512/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix LineLength warnings as much as possible if it can not be fixed by spotless
> ------------------------------------------------------------------------------
>
> Key: HBASE-26922
> URL: https://issues.apache.org/jira/browse/HBASE-26922
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.12
>
>
> One possible problem is the trailing comment, Like this
> {code}
> assertTrue(initialRegions
> .contains(RegionReplicaUtil.getRegionInfoForReplica(mergedRegions.getFirst(), 1))); // this
> // is
> // the
> // replica
> // of
> // the
> // first
> // region
> {code}
> Because of we limited line length, the format will be very strange and still has line length problem if some of the words are too long.
> Let's move them from trailing to top of the statement.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)