You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2008/12/03 01:00:44 UTC
[jira] Created: (HADOOP-4755) We should ignore serialization "bad
practice" warnings for jsp pages for findbugs
We should ignore serialization "bad practice" warnings for jsp pages for findbugs
---------------------------------------------------------------------------------
Key: HADOOP-4755
URL: https://issues.apache.org/jira/browse/HADOOP-4755
Project: Hadoop Core
Issue Type: Bug
Reporter: Boris Shkolnik
Priority: Minor
some jsp pages will get SE_BAD_FIELD warnings from FindBugs.
These warnings should be ignored. We currently get them for dfshealth.jsp and dfsnodelist.jsp files in webapps.
To do this we need to add class and bug pattern to findbugsExcludeFile.xml.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4755) We should ignore serialization "bad
practice" warnings for jsp pages for findbugs
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652685#action_12652685 ]
Suresh Srinivas commented on HADOOP-4755:
-----------------------------------------
What are the fields for which we are getting this error? As an alternative to turning off the warnings, some of these variables that cannot be serialized need to be changed to transient variable.
> We should ignore serialization "bad practice" warnings for jsp pages for findbugs
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-4755
> URL: https://issues.apache.org/jira/browse/HADOOP-4755
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Priority: Minor
>
> some jsp pages will get SE_BAD_FIELD warnings from FindBugs.
> These warnings should be ignored. We currently get them for dfshealth.jsp and dfsnodelist.jsp files in webapps.
> To do this we need to add class and bug pattern to findbugsExcludeFile.xml.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (HADOOP-4755) We should ignore serialization
"bad practice" warnings for jsp pages for findbugs
Posted by Suresh Srinivas <su...@yahoo-inc.com>.
What are the fields for which we are getting this error? As an alternative to turning off the warnings, some of these variables that cannot be serialized need to be changed to transient variable.
On 12/3/08 5:30 AM, "Boris Shkolnik (JIRA)" <ji...@apache.org> wrote:
We should ignore serialization "bad practice" warnings for jsp pages for findbugs
---------------------------------------------------------------------------------
Key: HADOOP-4755
URL: https://issues.apache.org/jira/browse/HADOOP-4755
Project: Hadoop Core
Issue Type: Bug
Reporter: Boris Shkolnik
Priority: Minor
some jsp pages will get SE_BAD_FIELD warnings from FindBugs.
These warnings should be ignored. We currently get them for dfshealth.jsp and dfsnodelist.jsp files in webapps.
To do this we need to add class and bug pattern to findbugsExcludeFile.xml.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4755) We should ignore serialization "bad
practice" warnings for jsp pages for findbugs
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654019#action_12654019 ]
Boris Shkolnik commented on HADOOP-4755:
----------------------------------------
for example:
Class org.apache.hadoop.hdfs.server.namenode.dfsnodelist_jsp defines non-transient non-serializable instance field _jspx_resourceInjector
Class org.apache.hadoop.hdfs.server.namenode.dfsnodelist_jsp defines non-transient non-serializable instance field jspHelper
We could make jspHelper transient (not sure if it makes sense though), but I don't think you can do anything about _jspx_resourceInjector (it is created when converting from jsp to _jsp.java.
> We should ignore serialization "bad practice" warnings for jsp pages for findbugs
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-4755
> URL: https://issues.apache.org/jira/browse/HADOOP-4755
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Priority: Minor
>
> some jsp pages will get SE_BAD_FIELD warnings from FindBugs.
> These warnings should be ignored. We currently get them for dfshealth.jsp and dfsnodelist.jsp files in webapps.
> To do this we need to add class and bug pattern to findbugsExcludeFile.xml.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.