[GitHub] [lucene-solr] mikemccand commented on pull request #1912: LUCENE-9535: Try to do larger flushes.

[GitBox <gi...@apache.org>]

mikemccand commented on pull request #1912:
URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-698332632


   Oh my!
   
   We are talking about assigning DWPT to incoming indexing thread, right?  (And not which DWPT to pick for flushing because RAM buffer is full, which I think is currently "the biggest one/s"?).
   
   I think this is a good idea.  It will tend to make the biggest DWPTs even bigger, especially when there is high variance of how many threads are indexing at once over time, until a flush is triggered.  I do not remember why we switched to "last DWPT".  Long ago we did have thread affinity, so the same indexing thread would try to get the same DWPT, but we moved away from that quite a while ago.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org