You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/25 21:17:19 UTC

[GitHub] [incubator-superset] serenajiang opened a new pull request #8284: [typing] superset/models/core.py

serenajiang opened a new pull request #8284: [typing] superset/models/core.py
URL: https://github.com/apache/incubator-superset/pull/8284
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [X] Documentation
   
   ### SUMMARY
   Added typing and various small rewrites/fixes to `superset/models/core.py`. wheeeeee.
   
   ### TEST PLAN
   Passes tox. Mostly just typing, so shouldn't affect functionality.
   
   ### REVIEWERS
   @etr2460 @john-bodley 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org