[GitHub] [hadoop] steveloughran commented on issue #1688: HADOOP-16742. Possible NPE in S3A MultiObjectDeleteSupport error handling.

[GitBox <gi...@apache.org>]

steveloughran commented on issue #1688: HADOOP-16742. Possible NPE in S3A MultiObjectDeleteSupport error handling.
URL: https://github.com/apache/hadoop/pull/1688#issuecomment-561247473
 
 
   Created [HADOOP-16742](https://issues.apache.org/jira/browse/HADOOP-16742). Possible NPE in S3A MultiObjectDeleteSupport error handling.
   
   
   I don't think that this solves it in the right way.
   
   The only way exitCode == null is if the previous error in the loop had a null value *and* no previous exit code had been set.
   
   If the endpoint is returning null exitCodes then we should the filtering on that rather than trying to recover from it. We also need to think about what to say if we go through the entire List of errors and nothing was returned. 
   
   Also, in the line above, we are including that null value in the string we are putting together.
   
   Proposed: before Line 95 add
   ```java
   if (code == null) {
     code = "";
   }
   ```
   
   This guarantees we'll never having no code value either in string report or in the condition which follows.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org