You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/29 08:52:51 UTC

[GitHub] [shardingsphere] jingshanglu opened a new pull request #7959: fix PostgreSQL union syntax definition

jingshanglu opened a new pull request #7959:
URL: https://github.com/apache/shardingsphere/pull/7959


   Fixes #7948 .
   
   Changes proposed in this pull request:
   - fix PostgreSQL union syntax definition
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #7959: fix PostgreSQL union syntax definition

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7959:
URL: https://github.com/apache/shardingsphere/pull/7959#issuecomment-719133078


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=h1) Report
   > Merging [#7959](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b2202c437a880d401a112890d5aeb64fde565578?el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7959/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7959      +/-   ##
   ============================================
   + Coverage     74.65%   74.72%   +0.07%     
     Complexity      538      538              
   ============================================
     Files          1447     1447              
     Lines         22775    22754      -21     
     Branches       4063     4061       -2     
   ============================================
   + Hits          17003    17004       +1     
   + Misses         4673     4652      -21     
   + Partials       1099     1098       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...shardingsphere/sql/parser/api/SQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9hcGkvU1FMUGFyc2VyRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ingsphere/sql/parser/hook/ParsingHookRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9ob29rL1BhcnNpbmdIb29rUmVnaXN0cnkuamF2YQ==) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...here/sql/parser/core/parser/SQLParserExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3BhcnNlci9TUUxQYXJzZXJFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ql/parser/core/parser/SQLParserFacadeRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3BhcnNlci9TUUxQYXJzZXJGYWNhZGVSZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../parser/core/visitor/SQLVisitorFacadeRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvU1FMVmlzaXRvckZhY2FkZVJlZ2lzdHJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...l/parser/engine/executor/RDLSQLParserExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9lbmdpbmUvZXhlY3V0b3IvUkRMU1FMUGFyc2VyRXhlY3V0b3IuamF2YQ==) | | | |
   | [...ent/standard/StandardSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zdGF0ZW1lbnQvc3RhbmRhcmQvU3RhbmRhcmRTUUxTdGF0ZW1lbnRQYXJzZXJFbmdpbmUuamF2YQ==) | | | |
   | [...engine/ShardingSphereSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9lbmdpbmUvU2hhcmRpbmdTcGhlcmVTUUxTdGF0ZW1lbnRQYXJzZXJFbmdpbmUuamF2YQ==) | | | |
   | [...ser/engine/engine/RDLSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9lbmdpbmUvZW5naW5lL1JETFNRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | | | |
   | [...re/rdl/parser/sql/parser/ShardingSphereParser.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9zcWwvcGFyc2VyL1NoYXJkaW5nU3BoZXJlUGFyc2VyLmphdmE=) | | | |
   | ... and [18 more](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=footer). Last update [b2202c4...d2fbc6a](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #7959: fix PostgreSQL union syntax definition

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #7959:
URL: https://github.com/apache/shardingsphere/pull/7959#issuecomment-719133078


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=h1) Report
   > Merging [#7959](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b2202c437a880d401a112890d5aeb64fde565578?el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7959/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7959      +/-   ##
   ============================================
   + Coverage     74.65%   74.72%   +0.07%     
     Complexity      538      538              
   ============================================
     Files          1447     1447              
     Lines         22775    22754      -21     
     Branches       4063     4061       -2     
   ============================================
   + Hits          17003    17004       +1     
   + Misses         4673     4652      -21     
   + Partials       1099     1098       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...shardingsphere/sql/parser/api/SQLParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9hcGkvU1FMUGFyc2VyRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ingsphere/sql/parser/hook/ParsingHookRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9ob29rL1BhcnNpbmdIb29rUmVnaXN0cnkuamF2YQ==) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...here/sql/parser/core/parser/SQLParserExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3BhcnNlci9TUUxQYXJzZXJFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ql/parser/core/parser/SQLParserFacadeRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3BhcnNlci9TUUxQYXJzZXJGYWNhZGVSZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../parser/core/visitor/SQLVisitorFacadeRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL3Zpc2l0b3IvU1FMVmlzaXRvckZhY2FkZVJlZ2lzdHJ5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...der/context/CreateDataSourcesStatementContext.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9iaW5kZXIvY29udGV4dC9DcmVhdGVEYXRhU291cmNlc1N0YXRlbWVudENvbnRleHQuamF2YQ==) | | | |
   | [...r/binder/util/ShardingAlgorithmPropertiesUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9iaW5kZXIvdXRpbC9TaGFyZGluZ0FsZ29yaXRobVByb3BlcnRpZXNVdGlsLmphdmE=) | | | |
   | [...re/rdl/parser/sql/parser/ShardingSphereParser.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9zcWwvcGFyc2VyL1NoYXJkaW5nU3BoZXJlUGFyc2VyLmphdmE=) | | | |
   | [...ser/engine/engine/RDLSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9lbmdpbmUvZW5naW5lL1JETFNRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | | | |
   | [...arser/binder/util/DataSourceConnectionUrlUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcmRsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1yZGwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcmRsL3BhcnNlci9iaW5kZXIvdXRpbC9EYXRhU291cmNlQ29ubmVjdGlvblVybFV0aWwuamF2YQ==) | | | |
   | ... and [18 more](https://codecov.io/gh/apache/shardingsphere/pull/7959/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=footer). Last update [b2202c4...d2fbc6a](https://codecov.io/gh/apache/shardingsphere/pull/7959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #7959: fix PostgreSQL union syntax definition

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7959:
URL: https://github.com/apache/shardingsphere/pull/7959


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org