You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/25 14:30:39 UTC

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4570: Externalize KVM Agent's option to change migration thread timeout

GabrielBrascher commented on pull request #4570:
URL: https://github.com/apache/cloudstack/pull/4570#issuecomment-847919516


   @rhtyd @GutoVeronezi my 2 cents here is: I think that PR #4586 has nothing to do with #4570.
   
   The first one externalizes the KVM agent **storage reboot configuration** (#4586), while the second one (#4570) allows configuring **migration thread timeout**. They are completely different variables, that impact distinct components and change different behaviors.
   
   The only thing that links both PRs is the `AgentPropertiesFileHandler`, which is basically using the same means to do a completely different thing.
   
   I see it as a personal way of seeing. One could keep two PRs as they affect different parts and could easily be debugged and done separately. On the other hand, one could have them on a generic PR such as `Externalize some KVM variables`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org