[GitHub] [spark] cloud-fan commented on a change in pull request #26001: [SPARK-29331][SQL] create DS v2 Write at physical plan

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #26001: [SPARK-29331][SQL] create DS v2 Write at physical plan
URL: https://github.com/apache/spark/pull/26001#discussion_r331096641
 
 

 ##########
 File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
 ##########
 @@ -50,7 +50,7 @@ private[kafka010] object KafkaWriter extends Logging {
       topic: Option[String] = None): Unit = {
     schema.find(_.name == TOPIC_ATTRIBUTE_NAME).getOrElse(
       if (topic.isEmpty) {
-        throw new AnalysisException(s"topic option required when no " +
+        throw new IllegalArgumentException(s"topic option required when no " +
 
 Review comment:
   If this is unacceptable, then we may need to have analysis time write info and runtime write info. `Table.newWriteBuilder` takes analysis time write info and `WriteBuilder.build` takes runtime write info.
   
   I'm not sure if it's worth this complexity.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org