You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Antony Stubbs (JIRA)" <ji...@apache.org> on 2008/11/10 11:36:46 UTC
[jira] Created: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Add an extension of AutoCompleteTextField which includes default css
--------------------------------------------------------------------
Key: WICKET-1921
URL: https://issues.apache.org/jira/browse/WICKET-1921
Project: Wicket
Issue Type: Improvement
Affects Versions: 1.4-M3
Reporter: Antony Stubbs
The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (WICKET-1921) Add an extension of AutoCompleteTextField which includes default css
Posted by Timo Rantalaiho <Ti...@ri.fi>.
Thanks Anthony!
Could you please provide your changes as a patch against the
current wicket trunk? That way it's a lot easier to review
and work with your change.
[jira] Updated: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Posted by "Antony Stubbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antony Stubbs updated WICKET-1921:
----------------------------------
Attachment: defaultcss.patch
> Add an extension of AutoCompleteTextField which includes default css
> --------------------------------------------------------------------
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4-M3
> Reporter: Antony Stubbs
> Attachments: defaultcss.patch, wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timo Rantalaiho resolved WICKET-1921.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.4-RC2
1.3.6
Thankyou Anthony! I added Apache License Header and inlined the protected getCss-method, so that people will not do stuff in there that you shouldn't do before the object construction is finished (that's the danger of calling overridable methods from constructors).
> Add an extension of AutoCompleteTextField which includes default css
> --------------------------------------------------------------------
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4-M3
> Reporter: Antony Stubbs
> Assignee: Timo Rantalaiho
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: defaultcss.patch, wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1921:
-------------------------------------
Assignee: Timo Rantalaiho
> Add an extension of AutoCompleteTextField which includes default css
> --------------------------------------------------------------------
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4-M3
> Reporter: Antony Stubbs
> Assignee: Timo Rantalaiho
> Attachments: defaultcss.patch, wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651413#action_12651413 ]
Timo Rantalaiho commented on WICKET-1921:
-----------------------------------------
Sure, there's a lot of examples of this in the web, some with concrete code examples. This one seemed OK looking at it briefly
http://benpryor.com/blog/2008/01/02/dont-call-subclass-methods-from-a-superclass-constructor/
> Add an extension of AutoCompleteTextField which includes default css
> --------------------------------------------------------------------
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4-M3
> Reporter: Antony Stubbs
> Assignee: Timo Rantalaiho
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: defaultcss.patch, wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Posted by "Antony Stubbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12651329#action_12651329 ]
Antony Stubbs commented on WICKET-1921:
---------------------------------------
No problem! Just thought it might be nice.
Hey - got any links to info around your statement "will not do stuff in there that you shouldn't do before the object construction is finished (that's the danger of calling overridable methods from constructors)." - i'm curious.
> Add an extension of AutoCompleteTextField which includes default css
> --------------------------------------------------------------------
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4-M3
> Reporter: Antony Stubbs
> Assignee: Timo Rantalaiho
> Fix For: 1.3.6, 1.4-RC2
>
> Attachments: defaultcss.patch, wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Posted by "Antony Stubbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antony Stubbs updated WICKET-1921:
----------------------------------
Attachment: wicket.rar
> Add an extension of AutoCompleteTextField which includes default css
> --------------------------------------------------------------------
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4-M3
> Reporter: Antony Stubbs
> Attachments: wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Posted by "Antony Stubbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646220#action_12646220 ]
Antony Stubbs commented on WICKET-1921:
---------------------------------------
p.s. if you do decide this is worthwhile, I would also include an @see DefaultCssAutocompleteTextField in AutocompleteTextField.
> Add an extension of AutoCompleteTextField which includes default css
> --------------------------------------------------------------------
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4-M3
> Reporter: Antony Stubbs
> Attachments: wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1921) Add an extension of
AutoCompleteTextField which includes default css
Posted by "Timo Rantalaiho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646247#action_12646247 ]
Timo Rantalaiho commented on WICKET-1921:
-----------------------------------------
Thanks Anthony!
Could you please provide your changes as a patch against the
current wicket trunk? That way it's a lot easier to review
and work with your change.
> Add an extension of AutoCompleteTextField which includes default css
> --------------------------------------------------------------------
>
> Key: WICKET-1921
> URL: https://issues.apache.org/jira/browse/WICKET-1921
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.4-M3
> Reporter: Antony Stubbs
> Attachments: wicket.rar
>
>
> The component doesn't seem to work very well without some basic CSS. Adding this will help people get started with it / demonstrate the css.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.