You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "shuyouZZ (via GitHub)" <gi...@apache.org> on 2023/10/26 03:36:28 UTC
[PR] SPARK-45668 Improve the assert message in RollingEventLogFilesFileReader [spark]
shuyouZZ opened a new pull request, #43533:
URL: https://github.com/apache/spark/pull/43533
### What changes were proposed in this pull request?
Update the assert message in `RollingEventLogFilesFileReader` to make it clearer.
### Why are the changes needed?
Currently the assert message in `RollingEventLogFilesFileReader` is not clear. When the assertion fails, it's difficult to find the event log file that is having problems.
In this ticket, we will update the following two places to make the assert message clearer.
- val files. Add `rootPath` field in the assert message.
- val eventLogFiles. Add new method `findMissingIndices`, only print the missing event log indices instead of all indices.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No need, just an assert message.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45668][CORE] Improve the assert message in RollingEventLogFilesFileReader [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43533:
URL: https://github.com/apache/spark/pull/43533#issuecomment-1925498466
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45668][CORE] Improve the assert message in RollingEventLogFilesFileReader [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #43533: [SPARK-45668][CORE] Improve the assert message in RollingEventLogFilesFileReader
URL: https://github.com/apache/spark/pull/43533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org