[jira] [Commented] (AVRO-1591) Java - handle hashCode / equals / toString in SpecificRequestor

["Doug Cutting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157505#comment-14157505 ] 

Doug Cutting commented on AVRO-1591:
------------------------------------

Can you please add some unit tests for this?

Also, copying code from Oracle sources is probably not a good idea.

> Java - handle hashCode / equals / toString in SpecificRequestor
> ---------------------------------------------------------------
>
>                 Key: AVRO-1591
>                 URL: https://issues.apache.org/jira/browse/AVRO-1591
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Mark Spadoni
>         Attachments: AVRO-1591.patch
>
>
> SpecificRequestor does not handle hashCode / equals / toString in its invoke method.  This problem cropped up when using commons-pool2's GenericKeyedObjectPool.create(), which attempts to put pool object wrappers into a map, keying off the original object:
> objectDeque.getAllObjects().put(p.getObject(), p);
> The put calls hashCode() which is not handled, resulting in an AvroRemoteException.
> See proposed patch for details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)