You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "stack (JIRA)" <ji...@apache.org> on 2007/07/06 18:46:05 UTC
[jira] Created: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Add hbase contrib lib dir to root build.xml javadoc classpath
-------------------------------------------------------------
Key: HADOOP-1571
URL: https://issues.apache.org/jira/browse/HADOOP-1571
Project: Hadoop
Issue Type: Improvement
Reporter: stack
Priority: Minor
hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511730 ]
Hudson commented on HADOOP-1571:
--------------------------------
Integrated in Hadoop-Nightly #151 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/151/])
> Add hbase contrib lib dir to root build.xml javadoc classpath
> -------------------------------------------------------------
>
> Key: HADOOP-1571
> URL: https://issues.apache.org/jira/browse/HADOOP-1571
> Project: Hadoop
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: contrib-lib-javadoc-v2.patch, contrib-lib-javadoc.patch
>
>
> hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
> Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510815 ]
Hadoop QA commented on HADOOP-1571:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12361324/contrib-lib-javadoc-v2.patch applied and successfully tested against trunk revision r553623.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/370/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/370/console
> Add hbase contrib lib dir to root build.xml javadoc classpath
> -------------------------------------------------------------
>
> Key: HADOOP-1571
> URL: https://issues.apache.org/jira/browse/HADOOP-1571
> Project: Hadoop
> Issue Type: Improvement
> Reporter: stack
> Priority: Minor
> Attachments: contrib-lib-javadoc-v2.patch, contrib-lib-javadoc.patch
>
>
> hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
> Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-1571:
------------------------------
Resolution: Fixed
Fix Version/s: 0.14.0
Assignee: stack
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Michael!
> Add hbase contrib lib dir to root build.xml javadoc classpath
> -------------------------------------------------------------
>
> Key: HADOOP-1571
> URL: https://issues.apache.org/jira/browse/HADOOP-1571
> Project: Hadoop
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: contrib-lib-javadoc-v2.patch, contrib-lib-javadoc.patch
>
>
> hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
> Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-1571:
--------------------------
Status: Patch Available (was: Open)
Passes all tests locally. Trying against hudson.
> Add hbase contrib lib dir to root build.xml javadoc classpath
> -------------------------------------------------------------
>
> Key: HADOOP-1571
> URL: https://issues.apache.org/jira/browse/HADOOP-1571
> Project: Hadoop
> Issue Type: Improvement
> Reporter: stack
> Priority: Minor
> Attachments: contrib-lib-javadoc-v2.patch, contrib-lib-javadoc.patch
>
>
> hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
> Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-1571:
--------------------------
Attachment: contrib-lib-javadoc.patch
Here is a suggested patch. It adds the hbase lib dir directly to the javadoc CLASSPATH in the root build.xml.
If folks have other suggestions for a solution, I'm all ears.
> Add hbase contrib lib dir to root build.xml javadoc classpath
> -------------------------------------------------------------
>
> Key: HADOOP-1571
> URL: https://issues.apache.org/jira/browse/HADOOP-1571
> Project: Hadoop
> Issue Type: Improvement
> Reporter: stack
> Priority: Minor
> Attachments: contrib-lib-javadoc.patch
>
>
> hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
> Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510772 ]
Doug Cutting commented on HADOOP-1571:
--------------------------------------
In general, this looks reasonable. We might include all src/contrib/*/lib directories, so that other contrib modules won't have to make this change again if they add libraries.
> Add hbase contrib lib dir to root build.xml javadoc classpath
> -------------------------------------------------------------
>
> Key: HADOOP-1571
> URL: https://issues.apache.org/jira/browse/HADOOP-1571
> Project: Hadoop
> Issue Type: Improvement
> Reporter: stack
> Priority: Minor
> Attachments: contrib-lib-javadoc.patch
>
>
> hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
> Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-1571:
--------------------------
Attachment: contrib-lib-javadoc-v2.patch
Thanks for the suggestion on how to generalize inclusion of libs D. Attached is a slight varient on your suggestion -- one that doesn't complain about missing contrib lib dirs.
> Add hbase contrib lib dir to root build.xml javadoc classpath
> -------------------------------------------------------------
>
> Key: HADOOP-1571
> URL: https://issues.apache.org/jira/browse/HADOOP-1571
> Project: Hadoop
> Issue Type: Improvement
> Reporter: stack
> Priority: Minor
> Attachments: contrib-lib-javadoc-v2.patch, contrib-lib-javadoc.patch
>
>
> hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
> Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1571) Add hbase contrib lib dir to root
build.xml javadoc classpath
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12511184 ]
Jim Kellerman commented on HADOOP-1571:
---------------------------------------
+1
> Add hbase contrib lib dir to root build.xml javadoc classpath
> -------------------------------------------------------------
>
> Key: HADOOP-1571
> URL: https://issues.apache.org/jira/browse/HADOOP-1571
> Project: Hadoop
> Issue Type: Improvement
> Reporter: stack
> Priority: Minor
> Attachments: contrib-lib-javadoc-v2.patch, contrib-lib-javadoc.patch
>
>
> hbase is about to add a lib directory. In here we will add libs needed by hbase but that are not of use to the parent hadoop (e.g. the jline jar to support the pending hbase shell feature).
> Editing the hbase build.xml to add the new hbase lib directory to the CLASSPATH works for all targets but 'javadoc'. The javadoc target in the parent hadoop project does not delegate down to the the src/contrib/build.xml file as does compile, test, and clean targets. Even if it did, the javadoc tool does not seem to be amenable to incremental doc generation; it wants all src to hand before it starts to work.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.