You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by se...@apache.org on 2013/08/18 01:00:42 UTC
svn commit: r1515046 -
/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/utils/CloneUtils.java
Author: sebb
Date: Sat Aug 17 23:00:41 2013
New Revision: 1515046
URL: http://svn.apache.org/r1515046
Log:
Localise and document @SuppressWarnings
Modified:
httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/utils/CloneUtils.java
Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/utils/CloneUtils.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/utils/CloneUtils.java?rev=1515046&r1=1515045&r2=1515046&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/utils/CloneUtils.java (original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/client/utils/CloneUtils.java Sat Aug 17 23:00:41 2013
@@ -42,7 +42,6 @@ public class CloneUtils {
/**
* @since 4.3
*/
- @SuppressWarnings("unchecked")
public static <T> T cloneObject(final T obj) throws CloneNotSupportedException {
if (obj == null) {
return null;
@@ -56,7 +55,9 @@ public class CloneUtils {
throw new NoSuchMethodError(ex.getMessage());
}
try {
- return (T) m.invoke(obj, (Object []) null);
+ @SuppressWarnings("unchecked") // OK because clone() preserves the class
+ final T result = (T) m.invoke(obj, (Object []) null);
+ return result;
} catch (final InvocationTargetException ex) {
final Throwable cause = ex.getCause();
if (cause instanceof CloneNotSupportedException) {