You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "galtthedestroyer (via GitHub)" <gi...@apache.org> on 2023/02/13 21:27:11 UTC
[GitHub] [airflow] galtthedestroyer opened a new pull request, #29514: Update index.rst to clarify pushing sending logs to elasticsearch
galtthedestroyer opened a new pull request, #29514:
URL: https://github.com/apache/airflow/pull/29514
https://github.com/apache/airflow/blob/v2-5-stable/airflow/providers/elasticsearch/log/es_task_handler.py specifically states that airflow itself does not push logs to elasticsearch. It took me more than one work day of searching the internet until I realized that I could look through the source code.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #29514: Update index.rst to clarify pushing sending logs to elasticsearch
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #29514: Update index.rst to clarify pushing sending logs to elasticsearch
URL: https://github.com/apache/airflow/pull/29514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29514: Update index.rst to clarify pushing sending logs to elasticsearch
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29514:
URL: https://github.com/apache/airflow/pull/29514#issuecomment-1428711829
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #29514: Update index.rst to clarify pushing sending logs to elasticsearch
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29514:
URL: https://github.com/apache/airflow/pull/29514#issuecomment-1496752495
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29514: Update index.rst to clarify pushing sending logs to elasticsearch
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29514:
URL: https://github.com/apache/airflow/pull/29514#discussion_r1111057887
##########
docs/apache-airflow-providers-elasticsearch/logging/index.rst:
##########
@@ -49,7 +49,7 @@ To output task logs to stdout in JSON format, the following config could be used
.. _write-logs-elasticsearch-tls:
-Writing logs to Elasticsearch over TLS
+Reading logs from Elasticsearch over TLS
''''''''''''''''''''''''''''''''''''''
Review Comment:
Need to fix docs formats. I would recommend you check it locally in [Breeze](https://github.com/apache/airflow/blob/main/BREEZE.rst#building-the-documentation) before push changes, it takes less time for re-run CI, because it is your first contribution you need some one who has write access to repo to manually approve CI run for you
```console
WARNING: Title underline too short.
File path: apache-airflow-providers-elasticsearch/logging/index.rst (53)
48 | json_format = True
49 |
50 | .. _write-logs-elasticsearch-tls:
51 |
52 | Reading logs from Elasticsearch over TLS
> 53 | ''''''''''''''''''''''''''''''''''''''
54 |
55 | To add custom configurations to ElasticSearch (e.g. turning on ``ssl_verify``, adding a custom self-signed
56 | cert, etc.) use the ``elasticsearch_configs`` setting in your ``airflow.cfg``
57 |
58 | .. code-block:: ini
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org