You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2024/02/03 21:52:52 UTC
[PR] [MINOR][DOCS] Clean markup in NULL semantics documentation [spark]
nchammas opened a new pull request, #45014:
URL: https://github.com/apache/spark/pull/45014
### What changes were proposed in this pull request?
- Replace the manual table of contents with an automatically generated one.
- Tweak various bits of markup to clean up the presentation.
- Remove the unused `style` block.
### Why are the changes needed?
Various bits of markup on this page are inconsistent with the rest of our documentation and are not necessary.
### Does this PR introduce _any_ user-facing change?
Yes, it changes the TOC and formatting of the NULL semantics page.
### How was this patch tested?
I built the docs and reviewed them in my browser.
3.5.0 vs. this branch:
<img height="300px" src="https://github.com/apache/spark/assets/1039369/b8dc5bab-69c3-4267-80f4-815927d4afbb" /> <img height="300px" src="https://github.com/apache/spark/assets/1039369/e189bb44-5839-460f-8c4e-5c9c2ba60297" />
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Clean markup in NULL semantics documentation [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #45014: [MINOR][DOCS] Clean markup in NULL semantics documentation
URL: https://github.com/apache/spark/pull/45014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Clean markup in NULL semantics documentation [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #45014:
URL: https://github.com/apache/spark/pull/45014#issuecomment-1926146846
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org