[jira] Commented: (THRIFT-282) Emit Python docstrings

["David Reiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674376#action_12674376 ] 

David Reiss commented on THRIFT-282:
------------------------------------

It looks like you're not putting newlines between each attribute if they don't have doc text.  There is at least one other similar bug (for functions).

Also, it looks like you don't generate a doctext for structures if individual fields have doctext, but the structure does not.  Is this intentional?

Why do you sort the fields by key instead of leaving them in IDL order?

> Emit Python docstrings
> ----------------------
>
>                 Key: THRIFT-282
>                 URL: https://issues.apache.org/jira/browse/THRIFT-282
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Python)
>    Affects Versions: 0.1
>            Reporter: Carlos Valiente
>            Priority: Trivial
>             Fix For: 0.1
>
>         Attachments: THRIFT-282.diff
>
>
> This patch makes the Python compiler emit docstrings for Thrift structs, enums, services and service methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.