[GitHub] [incubator-superset] villebro commented on a change in pull request #8058: [WIP] Add typing to db_engine_specs

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8058: [WIP] Add typing to db_engine_specs
URL: https://github.com/apache/incubator-superset/pull/8058#discussion_r314978426
 
 

 ##########
 File path: superset/sql_parse.py
 ##########
 @@ -143,15 +146,20 @@ def as_create_table(self, table_name, overwrite=False):
         exec_sql += f"CREATE TABLE {table_name} AS \n{sql}"
         return exec_sql
 
-    def __extract_from_token(self, token, depth=0):
+    def __extract_from_token(self, token: Token):
 
 Review comment:
   I removed `depth`, as it had no functional utility (I'm assuming it was used during debugging during initial development). Could potentially be added back with a `max_depth` attribute to make sure it doesn't go too deep.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org