You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/29 09:07:27 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
utchoang opened a new pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762
Fixes #759
@rhtyd cc @svenvogel
Please review it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762#issuecomment-700592094
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/762 (JID-3536)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762#discussion_r496592208
##########
File path: src/views/compute/InstanceTab.vue
##########
@@ -354,6 +370,45 @@ export default {
this.secondaryIPs = response.listnicsresponse.nic[0].secondaryip
})
},
+ fetchGuestNetwork (networkid) {
Review comment:
@utchoang Is this method used anywhere ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762#discussion_r496594515
##########
File path: src/views/compute/InstanceTab.vue
##########
@@ -354,6 +370,45 @@ export default {
this.secondaryIPs = response.listnicsresponse.nic[0].secondaryip
})
},
+ fetchGuestNetwork (networkid) {
Review comment:
@davidjumani No. This is a function I testing. I'll remove it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762#issuecomment-700608814
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/762 (JID-3538)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762#issuecomment-700604139
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762#issuecomment-700603550
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762#issuecomment-700586465
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #762: vm: FIX - Add dropdown select IP for network type is Shared
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #762:
URL: https://github.com/apache/cloudstack-primate/pull/762#issuecomment-700585964
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org