[GitHub] [rocketmq] dongeforever commented on pull request #3616: [ISSUE 3613] bug fix, solve message hash conflict in index file

[GitBox <gi...@apache.org>]

dongeforever commented on pull request #3616:
URL: https://github.com/apache/rocketmq/pull/3616#issuecomment-996480155


   > There are some commented old code implementing topic and key check. Anyone know Why are these code commented？ https://github.com/apache/rocketmq/pull/3616/files#diff-005813abb0e69e737cbda0fa3dcb04dddd4ab165336fae9619af60ea577fe883L958-L966
   > 
   > ```java
   > //                    String[] keyArray = msg.getKeys().split(MessageConst.KEY_SEPARATOR);
   > //                    if (topic.equals(msg.getTopic())) {
   > //                        for (String k : keyArray) {
   > //                            if (k.equals(key)) {
   > //                                match = true;
   > //                                break;
   > //                            }
   > //                        }
   > //                    }
   > ```
   
   The logic is moved to client  in MQAdminImpl.queryMessage.
   Try to reduce the load of brokers.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org