[GitHub] [superset] genzgd commented on a diff in pull request #22039: feat: use a new official CH driver: clickhouse-connect

[GitBox <gi...@apache.org>]

genzgd commented on code in PR #22039:
URL: https://github.com/apache/superset/pull/22039#discussion_r1019370126


##########
docs/docs/databases/clickhouse.mdx:
##########
@@ -10,33 +10,33 @@ version: 1
 To use ClickHouse with Superset, you will need to add the following Python library:
 
 ```
-clickhouse-sqlalchemy>=0.2.2
+clickhouse-connect>=0.3.8
 ```
 
 If running Superset using Docker Compose, add the following to your `./docker/requirements-local.txt` file:
 
 ```
-clickhouse-sqlalchemy>=0.2.2
+clickhouse-connect>=0.3.8
 ```
 
 The recommended connector library for ClickHouse is
-[sqlalchemy-clickhouse](https://github.com/cloudflare/sqlalchemy-clickhouse).
+[clickhouse-connect](https://github.com/ClickHouse/clickhouse-connect).
 
 The expected connection string is formatted as follows:
 
 ```
-clickhouse+native://<user>:<password>@<host>:<port>/<database>[?options…]clickhouse://{username}:{password}@{hostname}:{port}/{database}
+clickhousedb+connect://<user>:<password>@<host>:<port>/<database>[?options…]clickhouse://{username}:{password}@{hostname}:{port}/{database}
 ```
 
 Here's a concrete example of a real connection string:
 
 ```
-clickhouse+native://demo:demo@github.demo.trial.altinity.cloud/default?secure=true
+clickhousedb+connect://demo:demo@github.demo.trial.altinity.cloud/default?secure=true
 ```
 
-If you're using Clickhouse locally on your computer, you can get away with using a native protocol URL that
+If you're using Clickhouse locally on your computer, you can get away with using a http protocol URL that
 uses the default user without a password (and doesn't encrypt the connection):
 
 ```
-clickhouse+native://localhost/default
+clickhousedb+connect://localhost/default

Review Comment:
   `+connect` is not required



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org