[GitHub] [lucene] dweiss commented on a change in pull request #465: LUCENE-10243: increase unicode versions of tokenizers to 12.1

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #465:
URL: https://github.com/apache/lucene/pull/465#discussion_r754836089



##########
File path: gradle/generation/icu.gradle
##########
@@ -283,35 +283,3 @@ configure(project(":lucene:analysis:common")) {
 
   regenerate.dependsOn wrapWithPersistentChecksums(generateUnicodePropsInternal, [ andThenTasks: ["spotlessJava", "spotlessJavaApply"] ])
 }
-

Review comment:
       Awesome that it's gone. :)

##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/email/UAX29URLEmailTokenizerImpl.jflex
##########
@@ -61,8 +61,10 @@ ExtFmtZwj           = [\p{WB:Format}\p{WB:Extend}\p{WB:ZWJ}]*
 //////////////////////////////////////////////////////////////////////////
 // Begin Emoji Macros - see documentation below, near the EMOJI_TYPE rule
 
-// TODO: Remove this include file when JFlex supports these properties directly (in Unicode 11.0+)

Review comment:
       Again, great so see this include gone.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org