You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/03 17:03:28 UTC
[GitHub] [incubator-pinot] mangrrua opened a new pull request #5791: New endpoint to get routing table for sql query
mangrrua opened a new pull request #5791:
URL: https://github.com/apache/incubator-pinot/pull/5791
`PinotBrokerDebug` API contains endpoint that get routing table for PQL query. This new endpoint gets routing table for SQL query.
What is the required for?
- Pinot is moving from PQL to the SQL, and would be good to get routing table for SQL query.
- In one use case, this was needed. In `spark-pinot-connector` (PR: [5787](https://github.com/apache/incubator-pinot/pull/5787)), connector receives routing table by sql query. Thus we needs this endpoint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg merged pull request #5791: New endpoint to get routing table for sql query
Posted by GitBox <gi...@apache.org>.
kishoreg merged pull request #5791:
URL: https://github.com/apache/incubator-pinot/pull/5791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mangrrua removed a comment on pull request #5791: New endpoint to get routing table for sql query
Posted by GitBox <gi...@apache.org>.
mangrrua removed a comment on pull request #5791:
URL: https://github.com/apache/incubator-pinot/pull/5791#issuecomment-668195859
> Can you please add an integration test case so that we dont break this across releases?
Yes i can, but i could not found any integration tests about `routing table endpoint for pql`. Where can i add it? @kishoreg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mangrrua commented on pull request #5791: New endpoint to get routing table for sql query
Posted by GitBox <gi...@apache.org>.
mangrrua commented on pull request #5791:
URL: https://github.com/apache/incubator-pinot/pull/5791#issuecomment-668195859
> Can you please add an integration test case so that we dont break this across releases?
Yes i can, but i could not found any integration tests about `routing table endpoint for pql`. Where can i add it? @kishoreg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org