You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/06 21:37:31 UTC
[GitHub] [airflow] mik-laj commented on a change in pull request #5664:
[AIRFLOW-XXX] fix all missing type annotation errors from dmypy
mik-laj commented on a change in pull request #5664: [AIRFLOW-XXX] fix all missing type annotation errors from dmypy
URL: https://github.com/apache/airflow/pull/5664#discussion_r311286371
##########
File path: airflow/api/auth/backend/default.py
##########
@@ -17,9 +17,23 @@
# specific language governing permissions and limitations
# under the License.
"""Default authentication backend - everything is allowed"""
+from typing import Optional
from functools import wraps
+from typing_extensions import Protocol
-CLIENT_AUTH = None
+
+class ClientAuthProtocol(Protocol):
+ """
+ Protocl type for CLIENT_AUTH
Review comment:
```suggestion
Protocl type for CLIENT_AUTH
```
```suggestion
Protocol type for CLIENT_AUTH
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services