[GitHub] [incubator-eventmesh] weihubeats commented on a diff in pull request #2793: [ISSUE #2732] Method calls keySet() just to call contains, use containsKey instead [EventMeshRecommendImpl]

[GitBox <gi...@apache.org>]

weihubeats commented on code in PR #2793:
URL: https://github.com/apache/incubator-eventmesh/pull/2793#discussion_r1061260100


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/recommend/EventMeshRecommendImpl.java:
##########
@@ -31,179 +31,233 @@
 import java.util.List;
 import java.util.Map;
 
-import lombok.extern.slf4j.Slf4j;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
-@Slf4j

Review Comment:
   I think since we use lombok we can use @ slf4j to simplify the log printing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org