[GitHub] [spark] juliuszsompolski commented on issue #25073: [SPARK-28293][SQL] Implement Spark's own GetTableTypesOperation

[GitBox <gi...@apache.org>]

juliuszsompolski commented on issue #25073: [SPARK-28293][SQL] Implement Spark's own GetTableTypesOperation
URL: https://github.com/apache/spark/pull/25073#issuecomment-509273235
 
 
   Hi @wangyum,
   I would have to research a bit, but
   - SparkGetFunctionsOperations seems like an useful addition, modeled after SHOW FUNCTIONS / DESCRIBE FUNCTION
   - SparkGetTypeInfoOperation... I'm not sure. I think Spark type should be compatible with Hive types, otherwise we would be in trouble because of using Hive result set serialization?
   
   As for others:
   - I think we don't need GetCatalogs, am I right to assume it will just return null right now?
   - I think we could override GetPrimaryKeys and GetCrossReference operations to just return empty, as even if Spark is connected to an external catalog that contains such reference info, Spark does not utilize these, so better not return them to the tool that may assume that Spark respects these constraints.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org