svn commit: r1889885 - in /poi/trunk: poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/ poi/src/test/java/org/apache/poi/ss/usermodel/

[ce...@apache.org]

Author: centic
Date: Fri May 14 08:20:45 2021
New Revision: 1889885

URL: http://svn.apache.org/viewvc?rev=1889885&view=rev
Log:
Try to fix compiling on some CI-runs to support all active types of JDKs

Modified:
    poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestDeferredSXSSFWorkbook.java
    poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java
    poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestWorkbook.java

Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestDeferredSXSSFWorkbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestDeferredSXSSFWorkbook.java?rev=1889885&r1=1889884&r2=1889885&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestDeferredSXSSFWorkbook.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestDeferredSXSSFWorkbook.java Fri May 14 08:20:45 2021
@@ -58,8 +58,8 @@ public final class TestDeferredSXSSFWork
      */
     @Override
     @Test
-    protected void cloneSheet() throws IOException {
-        RuntimeException e = assertThrows(RuntimeException.class, () -> super.cloneSheet());
+    public void cloneSheet() throws IOException {
+        RuntimeException e = assertThrows(RuntimeException.class, super::cloneSheet);
         assertEquals("Not Implemented", e.getMessage());
     }
 
@@ -68,8 +68,8 @@ public final class TestDeferredSXSSFWork
      */
     @Override
     @Test
-    protected void sheetClone() throws IOException {
-        RuntimeException e = assertThrows(RuntimeException.class, () -> super.sheetClone());
+    public void sheetClone() {
+        RuntimeException e = assertThrows(RuntimeException.class, super::sheetClone);
         assertEquals("Not Implemented", e.getMessage());
     }
 

Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java?rev=1889885&r1=1889884&r2=1889885&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFWorkbook.java Fri May 14 08:20:45 2021
@@ -72,7 +72,7 @@ public final class TestSXSSFWorkbook ext
      */
     @Override
     @Test
-    protected void cloneSheet() throws IOException {
+    public void cloneSheet() throws IOException {
         RuntimeException e = assertThrows(RuntimeException.class, super::cloneSheet);
         assertEquals("Not Implemented", e.getMessage());
     }
@@ -82,7 +82,7 @@ public final class TestSXSSFWorkbook ext
      */
     @Override
     @Test
-    protected void sheetClone() {
+    public void sheetClone() {
         RuntimeException e = assertThrows(RuntimeException.class, super::sheetClone);
         assertEquals("Not Implemented", e.getMessage());
     }
@@ -358,6 +358,7 @@ public final class TestSXSSFWorkbook ext
 
     @Disabled("Crashes the JVM because of documented JVM behavior with concurrent writing/reading of zip-files, "
             + "see http://www.oracle.com/technetwork/java/javase/documentation/overview-156328.html")
+	@Test
     void bug53515a() throws Exception {
         File out = new File("Test.xlsx");
         assertTrue(!out.exists() || out.delete());
@@ -528,6 +529,7 @@ public final class TestSXSSFWorkbook ext
     }
 
     @Disabled("not implemented")
+	@Test
     void changeSheetNameWithSharedFormulas() {
     }
 }

Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestWorkbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestWorkbook.java?rev=1889885&r1=1889884&r2=1889885&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestWorkbook.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestWorkbook.java Fri May 14 08:20:45 2021
@@ -441,7 +441,7 @@ public abstract class BaseTestWorkbook {
     }
 
     @Test
-    protected void cloneSheet() throws IOException {
+    public void cloneSheet() throws IOException {
         try (Workbook book = _testDataProvider.createWorkbook()) {
             Sheet sheet = book.createSheet("TEST");
             sheet.createRow(0).createCell(0).setCellValue("Test");
@@ -804,7 +804,7 @@ public abstract class BaseTestWorkbook {
     }
 
     @Test
-    protected void sheetClone() throws IOException {
+    public void sheetClone() throws IOException {
         // First up, try a simple file
         try (Workbook b = _testDataProvider.createWorkbook();
              Workbook bBack = HSSFTestDataSamples.openSampleWorkbook("SheetWithDrawing.xls")) {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org