[GitHub] mistercrunch commented on a change in pull request #5736: [WIP][sqllab]More granular sqllab logging

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5736: [WIP][sqllab]More granular sqllab logging
URL: https://github.com/apache/incubator-superset/pull/5736#discussion_r212843078
 
 

 ##########
 File path: superset/migrations/versions/9a3c5cebcc67_.py
 ##########
 @@ -0,0 +1,29 @@
+"""empty message
+
+Revision ID: 9a3c5cebcc67
+Revises: 6400c588de5e
+Create Date: 2018-07-18 00:34:03.073314
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = '9a3c5cebcc67'
+down_revision = '6400c588de5e'
+
+from alembic import op
+import sqlalchemy as sa
+
+
+def upgrade():
+    op.alter_column('query', 'start_running_time', nullable=False, new_column_name='time_at_db')
 
 Review comment:
   This table tends to have hanging locks and is hard to alter. I've had issue every time I've had to alter this model where it just completely lock up everything. We'd all need to schedule downtime to allow for this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org