[GitHub] [hive] difin commented on a diff in pull request #3559: HIVE-26496,Improvement to fetch operator to scan only delete_delta fo…

[GitBox <gi...@apache.org>]

difin commented on code in PR #3559:
URL: https://github.com/apache/hive/pull/3559#discussion_r962084263


##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java:
##########
@@ -885,7 +886,20 @@ static Path[] getDeleteDeltaDirsFromSplit(OrcSplit orcSplit,
     } else {
       throw new IllegalStateException("Split w/o base w/Acid 2.0??: " + path);
     }
-    return AcidUtils.deserializeDeleteDeltas(root, orcSplit.getDeltas(), pathToDeltaMetaData);
+
+    // filtering out delete_delta folders containing transactions that happened only before
+    // transactions of the split
+    List<AcidInputFormat.DeltaMetaData> deltas = orcSplit.getDeltas();

Review Comment:
   Yes, I agree it is better and I made the filtering or irrelevant deltas to happen on the split initialization as suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org